Merge r243864 - [ATK] Wrong index passed to AtkObject::children-chang…

…ed::add signal in AXObjectCache::attachWrapper()

https://bugs.webkit.org/show_bug.cgi?id=196538

Reviewed by Michael Catanzaro.

In most of the cases the parent is not found, probably because the child is not a direct descendant of the
parent returned by parentObjectUnignored(). We need to handle the case of find() returning notFound.

* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::attachWrapper): Use -1 as the index when find() returns notFound.

Source/WebCore/ChangeLog

@@ -1,3 +1,16 @@
+2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [ATK] Wrong index passed to AtkObject::children-changed::add signal in AXObjectCache::attachWrapper()
+        https://bugs.webkit.org/show_bug.cgi?id=196538
+
+        Reviewed by Michael Catanzaro.
+
+        In most of the cases the parent is not found, probably because the child is not a direct descendant of the
+        parent returned by parentObjectUnignored(). We need to handle the case of find() returning notFound.
+
+        * accessibility/atk/AXObjectCacheAtk.cpp:
+        (WebCore::AXObjectCache::attachWrapper): Use -1 as the index when find() returns notFound.
+
 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
 
         Documents can be destroyed before their CSSFontFaceSet is destroyed

Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp

@@ -99,7 +99,7 @@ void AXObjectCache::attachWrapper(AccessibilityObject* obj)
         return;
 
     size_t index = coreParent->children(false).find(obj);
-    g_signal_emit_by_name(atkParent, "children-changed::add", index, atkObj);
+    g_signal_emit_by_name(atkParent, "children-changed::add", index != notFound ? index : -1, atkObj);
 }
 
 static AccessibilityObject* getListObject(AccessibilityObject* object)