Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ BigSur Debug JSC ] Multiple .lockdown tests are constant failures
https://bugs.webkit.org/show_bug.cgi?id=248000 <rdar://problem/102442315> Reviewed by Yusuke Suzuki. This patch fixes some timeout failures when the JSC stress tests are run in the lockdown test mode. 1. Introduce @skipModes which allows tests to be skipped from a test mode. 2. Use @skipModes to skip tests that require the JIT from the lockdown test mode. This replaces the old method of checking $vm.useJIT() at runtime, which is less efficient. 3. Use @skipModes to skip tests that are too slow from the lockdown test mode when run on a debug build. 4. Use @skipModes to skip a few tests from the lockdown test mode because these tests are too slow even when run on a Release build with lockdown test mode. * JSTests/microbenchmarks/array-from-derived-object-func.js: * JSTests/microbenchmarks/array-from-object-func.js: * JSTests/microbenchmarks/bit-test-constant.js: * JSTests/microbenchmarks/bit-test-load.js: * JSTests/microbenchmarks/bit-test-nonconstant.js: * JSTests/microbenchmarks/data-view-accesses-2.js: * JSTests/microbenchmarks/delete-property-allocation-sinking.js: * JSTests/microbenchmarks/delete-property-inline-cache.js: * JSTests/microbenchmarks/delete-property-keeps-cacheable-structure.js: * JSTests/microbenchmarks/elidable-new-object-dag.js: * JSTests/microbenchmarks/elidable-new-object-then-call.js: * JSTests/microbenchmarks/elidable-new-object-tree.js: * JSTests/microbenchmarks/function-to-string.js: * JSTests/microbenchmarks/get-and-put-by-val-double-index-dont-fall-off-a-cliff.js: * JSTests/microbenchmarks/get-by-val-polymorphic-ic-1.js: * JSTests/microbenchmarks/get-by-val-polymorphic-ic-4.js: * JSTests/microbenchmarks/get-by-val-polymorphic-ic-5.js: * JSTests/microbenchmarks/get-private-name.js: * JSTests/microbenchmarks/hoist-get-by-offset-tower-with-inferred-types.js: * JSTests/microbenchmarks/int52-rand-function.js: * JSTests/microbenchmarks/memcpy-loop.js: * JSTests/microbenchmarks/memcpy-typed-loop-large.js: * JSTests/microbenchmarks/object-is.js: * JSTests/microbenchmarks/obvious-sink-pathology-taken.js: * JSTests/microbenchmarks/oob-sane-chain-double.js: * JSTests/microbenchmarks/polyvariant-delete-property.js: * JSTests/microbenchmarks/richards-empty-try-catch.js: * JSTests/microbenchmarks/richards-try-catch.js: * JSTests/microbenchmarks/sinkable-new-object-dag.js: * JSTests/microbenchmarks/sinkable-new-object-taken.js: * JSTests/microbenchmarks/sinkable-new-object-with-builtin-constructor.js: * JSTests/microbenchmarks/sinkable-new-object.js: * JSTests/microbenchmarks/string-replace-string.js: * JSTests/microbenchmarks/to-number-boolean.js: * JSTests/microbenchmarks/typed-array-get-set-by-val-profiling.js: * JSTests/stress/allow-math-ic-b3-code-duplication.js: * JSTests/stress/arith-abs-on-various-types.js: * JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js: * JSTests/stress/arith-acos-on-various-types.js: * JSTests/stress/arith-acosh-on-various-types.js: * JSTests/stress/arith-asin-on-various-types.js: * JSTests/stress/arith-asinh-on-various-types.js: * JSTests/stress/arith-atan-on-various-types.js: * JSTests/stress/arith-atanh-on-various-types.js: * JSTests/stress/arith-cbrt-on-various-types.js: * JSTests/stress/arith-ceil-on-various-types.js: * JSTests/stress/arith-clz32-on-various-types.js: * JSTests/stress/arith-cos-on-various-types.js: * JSTests/stress/arith-cosh-on-various-types.js: * JSTests/stress/arith-expm1-on-various-types.js: * JSTests/stress/arith-floor-on-various-types.js: * JSTests/stress/arith-fround-on-various-types.js: * JSTests/stress/arith-log10-on-various-types.js: * JSTests/stress/arith-log2-on-various-types.js: * JSTests/stress/arith-negate-on-various-types.js: * JSTests/stress/arith-round-on-various-types.js: * JSTests/stress/arith-sin-on-various-types.js: * JSTests/stress/arith-sinh-on-various-types.js: * JSTests/stress/arith-sqrt-on-various-types.js: * JSTests/stress/arith-tan-on-various-types.js: * JSTests/stress/arith-tanh-on-various-types.js: * JSTests/stress/arith-trunc-on-various-types.js: * JSTests/stress/bit-op-with-object-returning-int32.js: * JSTests/stress/bitwise-not-fixup-rules.js: * JSTests/stress/call-var-args-phantom-arguments-handler-strict.js: * JSTests/stress/call-var-args-phantom-arguments-strict.js: * JSTests/stress/checkpoint-osr-exit-needs-to-reload-baseline-jit-constant-pool-gpr.js: * JSTests/stress/compare-strict-eq-on-various-types.js: * JSTests/stress/elide-new-object-dag-then-exit.js: * JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-bad-transition-debug.js: * JSTests/stress/int8-repeat-in-then-out-of-bounds.js: * JSTests/stress/new-regex-inline.js: * JSTests/stress/obviously-elidable-new-object-then-exit.js: * JSTests/stress/private-name-assignment-in-constructor.js: * JSTests/stress/spread-forward-call-varargs-stack-overflow.js: * JSTests/stress/tail-call-var-args-phantom-arguments-handler-strict.js: * JSTests/stress/tail-call-var-args-phantom-arguments-strict.js: * JSTests/stress/undecided-arrays-should-not-need-original-array-for-length.js: * JSTests/stress/v8-deltablue-strict.js: * JSTests/stress/v8-richards-strict.js: * PerformanceTests/JetStream/cdjs/main.js: * PerformanceTests/SunSpider/tests/v8-v6/v8-deltablue.js: * PerformanceTests/SunSpider/tests/v8-v6/v8-richards.js: * Tools/Scripts/run-jsc-stress-tests: Canonical link: https://commits.webkit.org/256875@main
- Loading branch information
Mark Lam
committed
Nov 19, 2022
1 parent
2d62c34
commit bb2a610
Showing
84 changed files
with
119 additions
and
97 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
//@ skip if not $jitTests | ||
//@ $skipModes << :lockdown | ||
let glob = 0 | ||
|
||
function doTest(number, bit) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
JSTests/microbenchmarks/delete-property-keeps-cacheable-structure.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
//@ $skipModes << :lockdown if $buildType == "debug" | ||
|
||
function f(x, y, z) { | ||
// comment in the body | ||
const w = 42; | ||
|
2 changes: 2 additions & 0 deletions
2
JSTests/microbenchmarks/get-and-put-by-val-double-index-dont-fall-off-a-cliff.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
//@ $skipModes << :lockdown if $buildType == "debug" | ||
|
||
function assert(b, m) { | ||
if (!b) | ||
throw new Error(m); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
//@ $skipModes << :lockdown if $buildType == "debug" | ||
|
||
function assert(b, m) { | ||
if (!b) | ||
throw new Error(m); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
//@ $skipModes << :lockdown if $buildType == "debug" | ||
|
||
function assert(b, m) { | ||
if (!b) | ||
throw new Error(m); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
JSTests/microbenchmarks/hoist-get-by-offset-tower-with-inferred-types.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
//@ $skipModes << :lockdown if $buildType == "debug" | ||
|
||
function assert(b) { | ||
if (!b) | ||
throw new Error; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
JSTests/microbenchmarks/sinkable-new-object-with-builtin-constructor.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
//@ $skipModes << :lockdown if $buildType == "debug" | ||
|
||
function test(a, b, c) | ||
{ | ||
return a.replace(b, c); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
JSTests/microbenchmarks/typed-array-get-set-by-val-profiling.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.