Skip to content

Commit

Permalink
UnifiedPDF: Remove an unused method
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=269443
rdar://122996119

Reviewed by Sammy Gill.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::contentSizeRespectingZoom const): Deleted.
This is only called from PDFPlugin so evict it from PDFPluginBase and UnifiedPDFPlugin.

Canonical link: https://commits.webkit.org/274805@main
  • Loading branch information
hortont424 committed Feb 16, 2024
1 parent 9ac8eb8 commit bc47043
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class PDFPlugin final : public PDFPluginBase {
WebCore::FloatRect convertFromPDFViewToScreen(const WebCore::FloatRect&) const;

CGFloat scaleFactor() const override;
CGSize contentSizeRespectingZoom() const final;
CGSize contentSizeRespectingZoom() const;

private:
explicit PDFPlugin(WebCore::HTMLPlugInElement&);
Expand Down
1 change: 0 additions & 1 deletion Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ class PDFPluginBase : public ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr<PDF
virtual void paint(WebCore::GraphicsContext&, const WebCore::IntRect&) { }

virtual CGFloat scaleFactor() const = 0;
virtual CGSize contentSizeRespectingZoom() const = 0;

virtual CGFloat minScaleFactor() const { return 0.25; }
virtual CGFloat maxScaleFactor() const { return 5; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ class UnifiedPDFPlugin final : public PDFPluginBase, public WebCore::GraphicsLay
float scaleForFitToView() const;

CGFloat scaleFactor() const override;
CGSize contentSizeRespectingZoom() const final;

void didBeginMagnificationGesture() override;
void didEndMagnificationGesture() override;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -813,11 +813,6 @@ static String mutationObserverNotificationString()
return m_scaleFactor;
}

CGSize UnifiedPDFPlugin::contentSizeRespectingZoom() const
{
return { };
}

float UnifiedPDFPlugin::deviceScaleFactor() const
{
return PDFPluginBase::deviceScaleFactor();
Expand Down

0 comments on commit bc47043

Please sign in to comment.