Improve test coverage of sink values - part2.

https://bugs.webkit.org/show_bug.cgi?id=273763 Reviewed by Tim Nguyen. Add checks on sink values. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-report-only.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy.html: Specifically for default policy test files. Canonical link: https://commits.webkit.org/278804@main
WebKit · May 15, 2024 · bcace83 · bcace83
1 parent d48536f
commit bcace83
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 4 deletions.
diff --git a/...ests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments.html b/...ests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments.html
@@ -17,6 +17,17 @@
       assert_equals(args[0], current_case[0], "Expecting the value.");
       assert_equals(args[1], current_case[1], "Expecting the type name.");
       assert_equals(args[2], current_case[2], "Expecting the sink name.");
+      switch (args[1]) {
+        case TrustedScriptURL:
+          assert_equals(args[2], 'HTMLScriptElement src');
+          break;
+        case TrustedHTML:
+          assert_equals(args[2], 'Element innerHTML');
+          break;
+        case TrustedScript:
+          assert_equals(args[2], 'HTMLScriptElement text');
+          break;
+      }
       return args[0];
     }
 

diff --git a/LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-report-only.html b/LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-report-only.html
@@ -54,7 +54,7 @@
 });
 
 // A trusted type policy that forces a number of edge cases.
-function policy(str) {
+function policy(str, type, sink) {
   if (str == "throw")
     throw RangeError();
   else if (str == "null")
@@ -65,8 +65,20 @@
     return document.bla();
   else if (str == "done")
     return null;
-  else
+  else {
+    switch (type) {
+      case TrustedScriptURL:
+        assert_equals(sink, 'HTMLScriptElement src');
+        break;
+      case TrustedHTML:
+        assert_equals(sink, 'Element innerHTML');
+        break;
+      case TrustedScript:
+        assert_equals(sink, 'HTMLScriptElement text');
+        break;
+    }
     return "sanitized: " + str;
+  }
 }
 
 trustedTypes.createPolicy("default", {

diff --git a/LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy.html b/LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy.html
@@ -54,7 +54,7 @@
 });
 
 // A trusted type policy that forces a number of edge cases.
-function policy(str) {
+function policy(str, type, sink) {
   if (str == "throw")
     throw RangeError();
   else if (str == "null")
@@ -65,8 +65,20 @@
     return document.bla();
   else if (str == "done")
     return null;
-  else
+  else {
+    switch (type) {
+      case TrustedScriptURL:
+        assert_equals(sink, 'HTMLScriptElement src');
+        break;
+      case TrustedHTML:
+        assert_equals(sink, 'Element innerHTML');
+        break;
+      case TrustedScript:
+        assert_equals(sink, 'HTMLScriptElement text');
+        break;
+    }
     return "sanitized: " + str;
+  }
 }
 
 trustedTypes.createPolicy("default", {