Skip to content

Commit

Permalink
AX: Add AXCorObject.cpp and move methods implementation from Accessib…
Browse files Browse the repository at this point in the history
…ilityObjectInterface.h.

https://bugs.webkit.org/show_bug.cgi?id=261742
<rdar://problem/115725555>

Reviewed by Tyler Wilcock.

Needed a cpp file to contain the implementation of AXCoreObject methods. Moved to the new AXCoreObject.cpp those methods that were in the header file that are not actually inline methods. Renamed the AccessibilityObjectInterface.h header to AXCoreObject.h since that is the main declaration in that header.

Canonical link: https://commits.webkit.org/268217@main
  • Loading branch information
AndresGonzalezApple committed Sep 20, 2023
1 parent 32aa453 commit bcba489
Show file tree
Hide file tree
Showing 20 changed files with 386 additions and 348 deletions.
2 changes: 1 addition & 1 deletion Source/WebCore/Headers.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,7 @@ set(WebCore_PRIVATE_FRAMEWORK_HEADERS
Modules/websockets/WebSocketIdentifier.h
Modules/websockets/WebSocketHandshake.h

accessibility/AXCoreObject.h
accessibility/AXGeometryManager.h
accessibility/AXLogger.h
accessibility/AXObjectCache.h
Expand All @@ -648,7 +649,6 @@ set(WebCore_PRIVATE_FRAMEWORK_HEADERS
accessibility/AccessibilityMockObject.h
accessibility/AccessibilityNodeObject.h
accessibility/AccessibilityObject.h
accessibility/AccessibilityObjectInterface.h
accessibility/AccessibilityRenderObject.h
accessibility/AccessibilityScrollView.h
accessibility/ForcedAccessibilityValue.h
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/Sources.txt
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,7 @@ Modules/webxr/XRInputSourceEvent.cpp
Modules/webxr/XRInputSourcesChangeEvent.cpp
Modules/webxr/XRReferenceSpaceEvent.cpp
Modules/webxr/XRSessionEvent.cpp
accessibility/AXCoreObject.cpp
accessibility/AXGeometryManager.cpp
accessibility/AXImage.cpp
accessibility/AXLogger.cpp
Expand Down
10 changes: 6 additions & 4 deletions Source/WebCore/WebCore.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@
26F9A83918A046AC00AEB88A /* ViewportConfiguration.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F9A83718A046AC00AEB88A /* ViewportConfiguration.h */; settings = {ATTRIBUTES = (Private, ); }; };
27E3C808257F5E6E00C986AB /* ANGLEHeaders.h in Headers */ = {isa = PBXBuildFile; fileRef = 27E3C806257F5E6E00C986AB /* ANGLEHeaders.h */; settings = {ATTRIBUTES = (Private, ); }; };
2914E3081CAB5A440049966F /* AccessibilityAttachment.h in Headers */ = {isa = PBXBuildFile; fileRef = 2914E3061CAB5A440049966F /* AccessibilityAttachment.h */; };
2936BF5C21D69E4B004A8FC9 /* AccessibilityObjectInterface.h in Headers */ = {isa = PBXBuildFile; fileRef = 2936BF5A21D6999E004A8FC9 /* AccessibilityObjectInterface.h */; settings = {ATTRIBUTES = (Private, ); }; };
2936BF5C21D69E4B004A8FC9 /* AXCoreObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 2936BF5A21D6999E004A8FC9 /* AXCoreObject.h */; settings = {ATTRIBUTES = (Private, ); }; };
293EAE1F1356B2FE0067ACF9 /* RuntimeApplicationChecks.h in Headers */ = {isa = PBXBuildFile; fileRef = 293EAE1E1356B2FE0067ACF9 /* RuntimeApplicationChecks.h */; settings = {ATTRIBUTES = (Private, ); }; };
29489FC712C00F0300D83F0F /* AccessibilityScrollView.h in Headers */ = {isa = PBXBuildFile; fileRef = 29489FC512C00F0300D83F0F /* AccessibilityScrollView.h */; };
297BE3D516C03C08003316BD /* PlatformSpeechSynthesisUtterance.h in Headers */ = {isa = PBXBuildFile; fileRef = 2527CC9116BF8BA1009DDAC0 /* PlatformSpeechSynthesisUtterance.h */; settings = {ATTRIBUTES = (Private, ); }; };
Expand Down Expand Up @@ -8840,7 +8840,7 @@
28DB9BC72020EA0400E54A07 /* PerformanceServerTiming.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = PerformanceServerTiming.idl; sourceTree = "<group>"; };
2914E3051CAB5A440049966F /* AccessibilityAttachment.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AccessibilityAttachment.cpp; sourceTree = "<group>"; };
2914E3061CAB5A440049966F /* AccessibilityAttachment.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AccessibilityAttachment.h; sourceTree = "<group>"; };
2936BF5A21D6999E004A8FC9 /* AccessibilityObjectInterface.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AccessibilityObjectInterface.h; sourceTree = "<group>"; };
2936BF5A21D6999E004A8FC9 /* AXCoreObject.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AXCoreObject.h; sourceTree = "<group>"; };
293EAE1E1356B2FE0067ACF9 /* RuntimeApplicationChecks.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RuntimeApplicationChecks.h; sourceTree = "<group>"; };
29489FC512C00F0300D83F0F /* AccessibilityScrollView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AccessibilityScrollView.h; sourceTree = "<group>"; };
29498681195341940072D2BD /* TextUndoInsertionMarkupMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = TextUndoInsertionMarkupMac.mm; sourceTree = "<group>"; };
Expand Down Expand Up @@ -17563,6 +17563,7 @@
C0400C7E261CB3DB00AF44FA /* AXImage.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = AXImage.cpp; sourceTree = "<group>"; };
C046E1AB1208A9FE00BA2CF7 /* LocalizedStrings.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LocalizedStrings.cpp; sourceTree = "<group>"; };
C0493EB7244699E4009AAC80 /* AXLogger.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AXLogger.h; sourceTree = "<group>"; };
C05F94852AB8E1A70028AA39 /* AXCoreObject.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = AXCoreObject.cpp; sourceTree = "<group>"; };
C078376023DF253E00C9C5C8 /* AXIsolatedObjectMac.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = AXIsolatedObjectMac.mm; path = mac/AXIsolatedObjectMac.mm; sourceTree = "<group>"; };
C08F13A1244766DC00AB989F /* AXLogger.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = AXLogger.cpp; sourceTree = "<group>"; };
C0E208A029379C6E00C0D2D3 /* AXTextMarker.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AXTextMarker.h; sourceTree = "<group>"; };
Expand Down Expand Up @@ -23006,7 +23007,6 @@
2985709315CC532D006355CD /* AccessibilityNodeObject.h */,
2981CAA5131822EC00D12F2A /* AccessibilityObject.cpp */,
29A812180FBB9C1D00510293 /* AccessibilityObject.h */,
2936BF5A21D6999E004A8FC9 /* AccessibilityObjectInterface.h */,
A409C982116D0DDD007197BD /* AccessibilityProgressIndicator.cpp */,
A409C983116D0DDD007197BD /* AccessibilityProgressIndicator.h */,
2981CAA6131822EC00D12F2A /* AccessibilityRenderObject.cpp */,
Expand Down Expand Up @@ -23039,6 +23039,8 @@
A91C9FC01B659A6700AFFD54 /* AccessibilityTreeItem.cpp */,
A91C9FC11B659A6700AFFD54 /* AccessibilityTreeItem.h */,
A9EE448C210FC9AD00B6EAE6 /* AriaAttributes.idl */,
C05F94852AB8E1A70028AA39 /* AXCoreObject.cpp */,
2936BF5A21D6999E004A8FC9 /* AXCoreObject.h */,
486B8DC82A04500F00E00E73 /* AXGeometryManager.cpp */,
486B8DC62A043C0600E00E73 /* AXGeometryManager.h */,
C0400C7E261CB3DB00AF44FA /* AXImage.cpp */,
Expand Down Expand Up @@ -37013,7 +37015,6 @@
76CDD2F51103DA6600680521 /* AccessibilityMenuListPopup.h in Headers */,
29ACB212143E7128006BCA5F /* AccessibilityMockObject.h in Headers */,
29A812360FBB9C1D00510293 /* AccessibilityObject.h in Headers */,
2936BF5C21D69E4B004A8FC9 /* AccessibilityObjectInterface.h in Headers */,
A409C985116D0DDD007197BD /* AccessibilityProgressIndicator.h in Headers */,
48B5BF3729CA691700FEBE3B /* AccessibilityRegionContext.h in Headers */,
29A812390FBB9C1D00510293 /* AccessibilityRenderObject.h in Headers */,
Expand Down Expand Up @@ -37267,6 +37268,7 @@
41F898F628ED702A0070549C /* AvcEncoderConfig.h in Headers */,
CD336F6217F9F64700DDDCD0 /* AVTrackPrivateAVFObjCImpl.h in Headers */,
070363E6181A1CDC00C074A5 /* AVVideoCaptureSource.h in Headers */,
2936BF5C21D69E4B004A8FC9 /* AXCoreObject.h in Headers */,
486B8DC72A043C0600E00E73 /* AXGeometryManager.h in Headers */,
29AE213521ABA48A00869283 /* AXIsolatedObject.h in Headers */,
29AE212D21AB9EEB00869283 /* AXIsolatedTree.h in Headers */,
Expand Down
Loading

0 comments on commit bcba489

Please sign in to comment.