Skip to content

Commit

Permalink
Merge r225214 - [GTK] WebDriver: disable XSS auditor when running Web…
Browse files Browse the repository at this point in the history
…Driver tests

https://bugs.webkit.org/show_bug.cgi?id=180075

Reviewed by Carlos Alberto Lopez Perez.

Some tests are now doing inline('<script>window.alert()</script>') which is rejected by the XSS auditor because
the script source is part of the request URL.

* Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:
(WebDriverGtk.capabilities): Disable XSS auditor.
  • Loading branch information
carlosgcampos committed Dec 18, 2017
1 parent 2cbb72e commit bd1771d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
13 changes: 13 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,16 @@
2017-11-28 Carlos Garcia Campos <cgarcia@igalia.com>

[GTK] WebDriver: disable XSS auditor when running WebDriver tests
https://bugs.webkit.org/show_bug.cgi?id=180075

Reviewed by Carlos Alberto Lopez Perez.

Some tests are now doing inline('<script>window.alert()</script>') which is rejected by the XSS auditor because
the script source is part of the request URL.

* Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:
(WebDriverGtk.capabilities): Disable XSS auditor.

2017-11-28 Carlos Garcia Campos <cgarcia@igalia.com>

WebDriver: add timeout option to run-webdriver-tests script
Expand Down
Expand Up @@ -37,7 +37,7 @@ def browser_name(self):
def capabilities(self):
return {'webkitgtk:browserOptions': {
'binary': self._port._build_path('bin', 'MiniBrowser'),
'args': ['--automation', '--javascript-can-open-windows-automatically=true']}}
'args': ['--automation', '--javascript-can-open-windows-automatically=true', '--enable-xss-auditor=false']}}


register_driver('gtk', WebDriverGtk)

0 comments on commit bd1771d

Please sign in to comment.