Skip to content

Commit

Permalink
Unreviewed, reverting r263490@main.
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=256160

triggers flaky incoming audio rendering

Reverted changeset:

"[GStreamer][MediaStream] Make the source element behave as a stream from urisourcebin scope"
https://bugs.webkit.org/show_bug.cgi?id=256042
https://commits.webkit.org/263490@main

Canonical link: https://commits.webkit.org/263548@main
  • Loading branch information
webkit-commit-queue authored and philn committed May 1, 2023
1 parent f8114a2 commit bdfbcd3
Showing 1 changed file with 12 additions and 12 deletions.
Expand Up @@ -614,22 +614,21 @@ static void webkitMediaStreamSrcUriHandlerInit(gpointer gIface, gpointer)
#define webkit_media_stream_src_parent_class parent_class
WEBKIT_DEFINE_TYPE_WITH_CODE(WebKitMediaStreamSrc, webkit_media_stream_src, GST_TYPE_BIN, doInit)

static void webkitMediaStreamSrcGetProperty(GObject* object, guint propertyId, GValue* value, GParamSpec* pspec)
static void webkitMediaStreamSrcSetProperty(GObject* object, guint propertyId, const GValue*, GParamSpec* pspec)
{
switch (propertyId) {
case PROP_IS_LIVE: {
bool hasCaptureTrack = false;
auto* self = WEBKIT_MEDIA_STREAM_SRC_CAST(object);
for (auto& track : self->priv->tracks) {
if (track->isCaptureTrack()) {
hasCaptureTrack = true;
break;
}
}

g_value_set_boolean(value, hasCaptureTrack);
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propertyId, pspec);
break;
}
}

static void webkitMediaStreamSrcGetProperty(GObject* object, guint propertyId, GValue* value, GParamSpec* pspec)
{
switch (propertyId) {
case PROP_IS_LIVE:
g_value_set_boolean(value, TRUE);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propertyId, pspec);
break;
Expand Down Expand Up @@ -746,6 +745,7 @@ static void webkit_media_stream_src_class_init(WebKitMediaStreamSrcClass* klass)
gobjectClass->constructed = webkitMediaStreamSrcConstructed;
gobjectClass->dispose = webkitMediaStreamSrcDispose;
gobjectClass->get_property = webkitMediaStreamSrcGetProperty;
gobjectClass->set_property = webkitMediaStreamSrcSetProperty;

g_object_class_install_property(gobjectClass, PROP_IS_LIVE, g_param_spec_boolean("is-live", nullptr, nullptr,
TRUE, static_cast<GParamFlags>(G_PARAM_READABLE | G_PARAM_STATIC_STRINGS)));
Expand Down

0 comments on commit bdfbcd3

Please sign in to comment.