Remove UnprefixedFullscreenAPIEnabled preference

https://bugs.webkit.org/show_bug.cgi?id=271142 Reviewed by Tim Nguyen. It's been stable for over a year. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/dom/Document+Fullscreen.idl: * Source/WebCore/dom/DocumentOrShadowRoot+Fullscreen.idl: * Source/WebCore/dom/Element+Fullscreen.idl: * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::dispatchEventForNode): Canonical link: https://commits.webkit.org/276301@main
WebKit · Mar 18, 2024 · bf10e09 · bf10e09
1 parent 737de53
commit bf10e09
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 29 deletions.
diff --git a/Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml b/Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
@@ -6783,20 +6783,6 @@ UnifiedPDFEnabled:
       "ENABLE(UNIFIED_PDF_BY_DEFAULT)": true
       default: false
 
-UnprefixedFullscreenAPIEnabled:
-  type: bool
-  status: stable
-  category: dom
-  humanReadableName: "Unprefixed Fullscreen API"
-  humanReadableDescription: "Enable Unprefixed Fullscreen API"
-  defaultValue:
-    WebKitLegacy:
-      default: true
-    WebKit:
-      default: true
-    WebCore:
-      default: true
-
 UpgradeKnownHostsToHTTPSEnabled:
   type: bool
   status: internal

diff --git a/Source/WebCore/dom/Document+Fullscreen.idl b/Source/WebCore/dom/Document+Fullscreen.idl
@@ -30,11 +30,11 @@
     DisabledByQuirk=shouldDisableElementFullscreen,
     ImplementedBy=DocumentFullscreen
 ] partial interface Document {
-    [LegacyLenientSetter, EnabledBySetting=UnprefixedFullscreenAPIEnabled, ImplementedAs=fullscreenEnabled] readonly attribute boolean fullscreenEnabled;
-    [LegacyLenientSetter, Unscopable, EnabledBySetting=UnprefixedFullscreenAPIEnabled, ImplementedAs=webkitIsFullScreen] readonly attribute boolean fullscreen; // historical
-    [EnabledBySetting=UnprefixedFullscreenAPIEnabled] Promise<undefined> exitFullscreen();
-    [EnabledBySetting=UnprefixedFullscreenAPIEnabled] attribute EventHandler onfullscreenchange;
-    [EnabledBySetting=UnprefixedFullscreenAPIEnabled] attribute EventHandler onfullscreenerror;
+    [LegacyLenientSetter] readonly attribute boolean fullscreenEnabled;
+    [LegacyLenientSetter, Unscopable, ImplementedAs=webkitIsFullScreen] readonly attribute boolean fullscreen; // historical
+    Promise<undefined> exitFullscreen();
+    attribute EventHandler onfullscreenchange;
+    attribute EventHandler onfullscreenerror;
 
     // Legacy WebKit-specific versions.
     readonly attribute boolean webkitFullscreenEnabled;

diff --git a/Source/WebCore/dom/DocumentOrShadowRoot+Fullscreen.idl b/Source/WebCore/dom/DocumentOrShadowRoot+Fullscreen.idl
@@ -26,7 +26,6 @@
 // https://fullscreen.spec.whatwg.org/#api
 [
     Conditional=FULLSCREEN_API,
-    EnabledBySetting=UnprefixedFullscreenAPIEnabled,
     DisabledByQuirk=shouldDisableElementFullscreen,
     ImplementedBy=DocumentOrShadowRootFullscreen
 ] partial interface mixin DocumentOrShadowRoot {

diff --git a/Source/WebCore/dom/Element+Fullscreen.idl b/Source/WebCore/dom/Element+Fullscreen.idl
@@ -29,9 +29,9 @@
     EnabledBySetting=FullScreenEnabled,
     DisabledByQuirk=shouldDisableElementFullscreen
 ] partial interface Element {
-    [EnabledBySetting=UnprefixedFullscreenAPIEnabled] Promise<undefined> requestFullscreen(optional FullscreenOptions options = {});
-    [EnabledBySetting=UnprefixedFullscreenAPIEnabled] attribute EventHandler onfullscreenchange;
-    [EnabledBySetting=UnprefixedFullscreenAPIEnabled] attribute EventHandler onfullscreenerror;
+    Promise<undefined> requestFullscreen(optional FullscreenOptions options = {});
+    attribute EventHandler onfullscreenchange;
+    attribute EventHandler onfullscreenerror;
 
     // Non-standard: WebKit prefixed variants.
     [ImplementedAs=webkitRequestFullscreen] undefined webkitRequestFullScreen(); // Prefixed Mozilla version.

diff --git a/Source/WebCore/dom/FullscreenManager.cpp b/Source/WebCore/dom/FullscreenManager.cpp
@@ -671,19 +671,16 @@ void FullscreenManager::notifyAboutFullscreenChangeOrError()
 
 void FullscreenManager::dispatchEventForNode(Node& node, EventType eventType)
 {
-    bool supportsUnprefixedAPI = document().settings().unprefixedFullscreenAPIEnabled();
     switch (eventType) {
     case EventType::Change: {
-        if (supportsUnprefixedAPI)
-            node.dispatchEvent(Event::create(eventNames().fullscreenchangeEvent, Event::CanBubble::Yes, Event::IsCancelable::No, Event::IsComposed::Yes));
+        node.dispatchEvent(Event::create(eventNames().fullscreenchangeEvent, Event::CanBubble::Yes, Event::IsCancelable::No, Event::IsComposed::Yes));
         bool shouldEmitUnprefixed = !(node.hasEventListeners(eventNames().webkitfullscreenchangeEvent) && node.hasEventListeners(eventNames().fullscreenchangeEvent)) && !(node.document().hasEventListeners(eventNames().webkitfullscreenchangeEvent) && node.document().hasEventListeners(eventNames().fullscreenchangeEvent));
-        if (!supportsUnprefixedAPI || shouldEmitUnprefixed)
+        if (shouldEmitUnprefixed)
             node.dispatchEvent(Event::create(eventNames().webkitfullscreenchangeEvent, Event::CanBubble::Yes, Event::IsCancelable::No, Event::IsComposed::Yes));
         break;
     }
     case EventType::Error:
-        if (supportsUnprefixedAPI)
-            node.dispatchEvent(Event::create(eventNames().fullscreenerrorEvent, Event::CanBubble::Yes, Event::IsCancelable::No, Event::IsComposed::Yes));
+        node.dispatchEvent(Event::create(eventNames().fullscreenerrorEvent, Event::CanBubble::Yes, Event::IsCancelable::No, Event::IsComposed::Yes));
         node.dispatchEvent(Event::create(eventNames().webkitfullscreenerrorEvent, Event::CanBubble::Yes, Event::IsCancelable::No, Event::IsComposed::Yes));
         break;
     }