-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
https://bugs.webkit.org/show_bug.cgi?id=261079 rdar://114889625 Reviewed by Tim Nguyen. CSS invokes the URL parser normally and therefore always uses UTF-8 as its URL encoding: https://drafts.csswg.org/css-values/#url-processing. This aligns us with the standard and Gecko. * LayoutTests/http/tests/webarchive/test-css-url-encoding-expected.webarchive: * LayoutTests/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive: * LayoutTests/http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive: * LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/utf-8_include=css-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/windows-1251_include=css-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/windows-1252_include=css-expected.txt: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::completeURL const): Canonical link: https://commits.webkit.org/270169@main
- Loading branch information
Showing
7 changed files
with
42 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
...sts/html/infrastructure/urls/resolving-urls/query-encoding/utf-8_include=css-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,23 @@ | ||
|
|
||
| PASS CSS <link> (utf-8) #<id> { background-image:<url> } | ||
| FAIL CSS <link> (windows-1252) #<id> { background-image:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <link> (windows-1252) #<id> { background-image:<url> } | ||
| PASS CSS <style> #<id> { background-image:<url> } | ||
| PASS CSS <link> (utf-8) #<id> { border-image-source:<url> } | ||
| FAIL CSS <link> (windows-1252) #<id> { border-image-source:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <link> (windows-1252) #<id> { border-image-source:<url> } | ||
| PASS CSS <style> #<id> { border-image-source:<url> } | ||
| PASS CSS <link> (utf-8) #<id>::before { content:<url> } | ||
| FAIL CSS <link> (windows-1252) #<id>::before { content:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <link> (windows-1252) #<id>::before { content:<url> } | ||
| PASS CSS <style> #<id>::before { content:<url> } | ||
| PASS CSS <link> (utf-8) @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } | ||
| FAIL CSS <link> (windows-1252) @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <link> (windows-1252) @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } | ||
| PASS CSS <style> @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } | ||
| PASS CSS <link> (utf-8) #<id> { display:list-item; list-style-image:<url> } | ||
| FAIL CSS <link> (windows-1252) #<id> { display:list-item; list-style-image:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <link> (windows-1252) #<id> { display:list-item; list-style-image:<url> } | ||
| PASS CSS <style> #<id> { display:list-item; list-style-image:<url> } | ||
| PASS CSS <link> (utf-8) @import <url>; | ||
| PASS CSS <link> (windows-1252) @import <url>; | ||
| PASS CSS <style> @import <url>; | ||
| PASS CSS <link> (utf-8) #<id> { cursor:<url>, pointer } | ||
| FAIL CSS <link> (windows-1252) #<id> { cursor:<url>, pointer } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <link> (windows-1252) #<id> { cursor:<url>, pointer } | ||
| PASS CSS <style> #<id> { cursor:<url>, pointer } | ||
|
|
24 changes: 12 additions & 12 deletions
24
...l/infrastructure/urls/resolving-urls/query-encoding/windows-1251_include=css-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,23 @@ | ||
|
|
||
| FAIL CSS <link> (windows-1251) #<id> { background-image:<url> } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| PASS CSS <link> (windows-1251) #<id> { background-image:<url> } | ||
| PASS CSS <link> (utf-8) #<id> { background-image:<url> } | ||
| FAIL CSS <style> #<id> { background-image:<url> } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| FAIL CSS <link> (windows-1251) #<id> { border-image-source:<url> } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| PASS CSS <style> #<id> { background-image:<url> } | ||
| PASS CSS <link> (windows-1251) #<id> { border-image-source:<url> } | ||
| PASS CSS <link> (utf-8) #<id> { border-image-source:<url> } | ||
| FAIL CSS <style> #<id> { border-image-source:<url> } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| FAIL CSS <link> (windows-1251) #<id>::before { content:<url> } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| PASS CSS <style> #<id> { border-image-source:<url> } | ||
| PASS CSS <link> (windows-1251) #<id>::before { content:<url> } | ||
| PASS CSS <link> (utf-8) #<id>::before { content:<url> } | ||
| FAIL CSS <style> #<id>::before { content:<url> } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| FAIL CSS <link> (windows-1251) @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| PASS CSS <style> #<id>::before { content:<url> } | ||
| PASS CSS <link> (windows-1251) @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } | ||
| PASS CSS <link> (utf-8) @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } | ||
| FAIL CSS <style> @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| FAIL CSS <link> (windows-1251) #<id> { display:list-item; list-style-image:<url> } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| PASS CSS <style> @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } | ||
| PASS CSS <link> (windows-1251) #<id> { display:list-item; list-style-image:<url> } | ||
| PASS CSS <link> (utf-8) #<id> { display:list-item; list-style-image:<url> } | ||
| FAIL CSS <style> #<id> { display:list-item; list-style-image:<url> } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| PASS CSS <style> #<id> { display:list-item; list-style-image:<url> } | ||
| PASS CSS <link> (windows-1251) @import <url>; | ||
| PASS CSS <link> (utf-8) @import <url>; | ||
| PASS CSS <style> @import <url>; | ||
| FAIL CSS <link> (windows-1251) #<id> { cursor:<url>, pointer } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| PASS CSS <link> (windows-1251) #<id> { cursor:<url>, pointer } | ||
| PASS CSS <link> (utf-8) #<id> { cursor:<url>, pointer } | ||
| FAIL CSS <style> #<id> { cursor:<url>, pointer } assert_equals: expected "%C3%A5" but got "%26%23229%3B" | ||
| PASS CSS <style> #<id> { cursor:<url>, pointer } | ||
|
|
24 changes: 12 additions & 12 deletions
24
...l/infrastructure/urls/resolving-urls/query-encoding/windows-1252_include=css-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,23 @@ | ||
|
|
||
| FAIL CSS <link> (windows-1252) #<id> { background-image:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <link> (windows-1252) #<id> { background-image:<url> } | ||
| PASS CSS <link> (utf-8) #<id> { background-image:<url> } | ||
| FAIL CSS <style> #<id> { background-image:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| FAIL CSS <link> (windows-1252) #<id> { border-image-source:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <style> #<id> { background-image:<url> } | ||
| PASS CSS <link> (windows-1252) #<id> { border-image-source:<url> } | ||
| PASS CSS <link> (utf-8) #<id> { border-image-source:<url> } | ||
| FAIL CSS <style> #<id> { border-image-source:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| FAIL CSS <link> (windows-1252) #<id>::before { content:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <style> #<id> { border-image-source:<url> } | ||
| PASS CSS <link> (windows-1252) #<id>::before { content:<url> } | ||
| PASS CSS <link> (utf-8) #<id>::before { content:<url> } | ||
| FAIL CSS <style> #<id>::before { content:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| FAIL CSS <link> (windows-1252) @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <style> #<id>::before { content:<url> } | ||
| PASS CSS <link> (windows-1252) @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } | ||
| PASS CSS <link> (utf-8) @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } | ||
| FAIL CSS <style> @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| FAIL CSS <link> (windows-1252) #<id> { display:list-item; list-style-image:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <style> @font-face { font-family:<id>; src:<url> } #<id> { font-family:<id> } | ||
| PASS CSS <link> (windows-1252) #<id> { display:list-item; list-style-image:<url> } | ||
| PASS CSS <link> (utf-8) #<id> { display:list-item; list-style-image:<url> } | ||
| FAIL CSS <style> #<id> { display:list-item; list-style-image:<url> } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <style> #<id> { display:list-item; list-style-image:<url> } | ||
| PASS CSS <link> (windows-1252) @import <url>; | ||
| PASS CSS <link> (utf-8) @import <url>; | ||
| PASS CSS <style> @import <url>; | ||
| FAIL CSS <link> (windows-1252) #<id> { cursor:<url>, pointer } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <link> (windows-1252) #<id> { cursor:<url>, pointer } | ||
| PASS CSS <link> (utf-8) #<id> { cursor:<url>, pointer } | ||
| FAIL CSS <style> #<id> { cursor:<url>, pointer } assert_equals: expected "%C3%A5" but got "%E5" | ||
| PASS CSS <style> #<id> { cursor:<url>, pointer } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters