-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Duolingo continue/next bar trails off of viewport
https://bugs.webkit.org/show_bug.cgi?id=273526 <rdar://126777425> Reviewed by Antti Koivisto. When a box changes containing block through style mutation (e.g. by going from out-of-flow to inflow), its (grid/flex driven) override value becomes stale. (note that these override values are apparently sticky and we have to keep them around in-between layouts for example to be able to resolve percent padding values for getComputedStyle) * LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid-expected.html: Added. * LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid.html: Added. * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::layoutPositionedObject): Canonical link: https://commits.webkit.org/278209@main
- Loading branch information
1 parent
2a15afd
commit c1c858c
Showing
3 changed files
with
33 additions
and
0 deletions.
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<style> | ||
div { | ||
width: 400px; | ||
height: 300px; | ||
background-color: green; | ||
} | ||
</style> | ||
<div></div> |
22 changes: 22 additions & 0 deletions
22
LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
<style> | ||
.grid { | ||
width: 200px; | ||
|
||
display: grid; | ||
padding: 100px; | ||
position: relative; | ||
background-color: green; | ||
} | ||
|
||
#abs { | ||
position: absolute; | ||
background-color: green; | ||
width: 100%; | ||
height: 100px; | ||
} | ||
</style> | ||
<!-- PASS if in-flow leaf does not stick out of grid container --> | ||
<div class=grid><div><div id=abs><script> | ||
document.body.offsetHeight; | ||
abs.style.position = "static"; | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters