Skip to content

Commit

Permalink
Remove ThirdPartyIframeRedirectBlockingEnabled preference
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=265196

Reviewed by Timothy Hatcher.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking):

Canonical link: https://commits.webkit.org/271041@main
  • Loading branch information
annevk committed Nov 22, 2023
1 parent 331b2c1 commit c3e775c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
13 changes: 0 additions & 13 deletions Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6568,19 +6568,6 @@ TextRecognitionInVideosEnabled:
WebKit:
default: defaultTextRecognitionInVideosEnabled()

ThirdPartyIframeRedirectBlockingEnabled:
type: bool
status: mature
humanReadableName: "Block top-level redirects by third-party iframes"
humanReadableDescription: "Block top-level redirects by third-party iframes"
defaultValue:
WebKitLegacy:
default: true
WebKit:
default: true
WebCore:
default: true

ThreadedAnimationResolutionEnabled:
type: bool
status: unstable
Expand Down
3 changes: 0 additions & 3 deletions Source/WebCore/dom/Document.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4033,9 +4033,6 @@ void Document::willLoadFrameElement(const URL& frameURL)
// Prevent cross-site top-level redirects from third-party iframes unless the user has ever interacted with the frame.
bool Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking(LocalFrame& targetFrame, const URL& destinationURL)
{
if (!settings().thirdPartyIframeRedirectBlockingEnabled())
return false;

// Only prevent top frame navigations by subframes.
if (m_frame == &targetFrame || &targetFrame != &m_frame->tree().top())
return false;
Expand Down

0 comments on commit c3e775c

Please sign in to comment.