Skip to content

Commit

Permalink
Add logging when mouse events are not sent when waiting for a context…
Browse files Browse the repository at this point in the history
… menu to show

https://bugs.webkit.org/show_bug.cgi?id=273862
rdar://127713566

Reviewed by Abrar Rahman Protyasha and Wenson Hsieh.

There have been recent reports that web content has been unresponsive to mouse events. In 274771@main, I
made a change that could be related, but I’m not sure how. If this logging repeatedly appears when the
bug reproduces, we’ll know 274771@main is the cause.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processNextQueuedMouseEvent):

Canonical link: https://commits.webkit.org/278491@main
  • Loading branch information
charliewolfe committed May 8, 2024
1 parent 7bf250e commit c4a6aea
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Source/WebKit/UIProcess/WebPageProxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3534,6 +3534,7 @@ void WebPageProxy::processNextQueuedMouseEvent()

#if ENABLE(CONTEXT_MENUS)
if (m_waitingForContextMenuToShow) {
WEBPAGEPROXY_RELEASE_LOG(MouseHandling, "processNextQueuedMouseEvent: Waiting for context menu to show.");
mouseEventHandlingCompleted(event.type(), false);
return;
}
Expand Down

0 comments on commit c4a6aea

Please sign in to comment.