Skip to content

Commit

Permalink
Remove BloomFilter size limit
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=138549

Reviewed by Andreas Kling.

* wtf/BloomFilter.h: Remove the static_assert, the code works fine with somewhat larger sizes.



Canonical link: https://commits.webkit.org/156390@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@175810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
anttijk committed Nov 10, 2014
1 parent 45aba1e commit c728c9b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
9 changes: 9 additions & 0 deletions Source/WTF/ChangeLog
@@ -1,3 +1,12 @@
2014-11-09 Antti Koivisto <antti@apple.com>

Remove BloomFilter size limit
https://bugs.webkit.org/show_bug.cgi?id=138549

Reviewed by Andreas Kling.

* wtf/BloomFilter.h: Remove the static_assert, the code works fine with somewhat larger sizes.

2014-11-09 Chris Dumez <cdumez@apple.com>

Add a more correct way to compare floating point numbers and use it
Expand Down
2 changes: 0 additions & 2 deletions Source/WTF/wtf/BloomFilter.h
Expand Up @@ -37,8 +37,6 @@ template <unsigned keyBits>
class BloomFilter {
WTF_MAKE_FAST_ALLOCATED;
public:
static_assert(keyBits <= 16, "BloomFilter key size must be less than or equal to 16!");

static const size_t tableSize = 1 << keyBits;
static const unsigned keyMask = (1 << keyBits) - 1;
static uint8_t maximumCount() { return std::numeric_limits<uint8_t>::max(); }
Expand Down

0 comments on commit c728c9b

Please sign in to comment.