Skip to content

Commit

Permalink
Remove Quirk shouldDisableElementFullscreenQuirk for nfl.com
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=255021
rdar://107633365

Reviewed by Tim Nguyen.

This removes the fullscreen quirk for the nfl.com website.
It was required on iPad so that the controls of the video are
being displayed. It is not necessary anymore.

* Source/WebCore/dom/Document+Fullscreen.idl:
* Source/WebCore/dom/Element+Fullscreen.idl:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableElementFullscreenQuirk const): Deleted.
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/266757@main
  • Loading branch information
karlcow committed Aug 10, 2023
1 parent f318e27 commit c8e45de
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 25 deletions.
1 change: 0 additions & 1 deletion Source/WebCore/dom/Document+Fullscreen.idl
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
[
Conditional=FULLSCREEN_API,
EnabledBySetting=FullScreenEnabled,
DisabledByQuirk=shouldDisableElementFullscreen,
ImplementedBy=DocumentFullscreen
] partial interface Document {
[LegacyLenientSetter, EnabledBySetting=UnprefixedFullscreenAPIEnabled, ImplementedAs=fullscreenEnabled] readonly attribute boolean fullscreenEnabled;
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/dom/Element+Fullscreen.idl
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
// https://fullscreen.spec.whatwg.org/#api
[
Conditional=FULLSCREEN_API,
DisabledByQuirk=shouldDisableElementFullscreen,
EnabledBySetting=FullScreenEnabled
] partial interface Element {
[EnabledBySetting=UnprefixedFullscreenAPIEnabled] Promise<undefined> requestFullscreen(optional FullscreenOptions options = {});
Expand Down
20 changes: 0 additions & 20 deletions Source/WebCore/page/Quirks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -991,26 +991,6 @@ bool Quirks::shouldEnableLegacyGetUserMediaQuirk() const
}
#endif

// nfl.com rdar://58807210
bool Quirks::shouldDisableElementFullscreenQuirk() const
{
#if PLATFORM(IOS_FAMILY)
if (!needsQuirks())
return false;

if (m_shouldDisableElementFullscreenQuirk)
return m_shouldDisableElementFullscreenQuirk.value();

auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();

m_shouldDisableElementFullscreenQuirk = domain == "nfl.com"_s || domain.endsWith(".nfl.com"_s);

return m_shouldDisableElementFullscreenQuirk.value();
#else
return false;
#endif
}

// hulu.com rdar://55041979
bool Quirks::needsCanPlayAfterSeekedQuirk() const
{
Expand Down
3 changes: 0 additions & 3 deletions Source/WebCore/page/Quirks.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ class Quirks {
bool shouldEnableLegacyGetUserMediaQuirk() const;
#endif

bool shouldDisableElementFullscreenQuirk() const;

bool needsCanPlayAfterSeekedQuirk() const;

bool shouldAvoidPastingImagesAsWebContent() const;
Expand Down Expand Up @@ -198,7 +196,6 @@ class Quirks {
mutable std::optional<bool> m_needsFullscreenDisplayNoneQuirk;
mutable std::optional<bool> m_shouldAvoidPastingImagesAsWebContent;
#endif
mutable std::optional<bool> m_shouldDisableElementFullscreenQuirk;
#if ENABLE(TOUCH_EVENTS)
enum class ShouldDispatchSimulatedMouseEvents : uint8_t {
Unknown,
Expand Down

0 comments on commit c8e45de

Please sign in to comment.