Merge r241632 - Sample domainsVisited diagnostic logging

https://bugs.webkit.org/show_bug.cgi?id=194657 Reviewed by Ryosuke Niwa. Sample domainsVisited diagnostic logging, we are getting a lot of data from this key and this is hurting our other keys. * page/Page.cpp: (WebCore::Page::logNavigation):
WebKit · Feb 18, 2019 · ca12d42 · ca12d42
1 parent c59d9bf
commit ca12d42
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2019-02-15  Chris Dumez  <cdumez@apple.com>
+
+        Sample domainsVisited diagnostic logging
+        https://bugs.webkit.org/show_bug.cgi?id=194657
+
+        Reviewed by Ryosuke Niwa.
+
+        Sample domainsVisited diagnostic logging, we are getting a lot of data from
+        this key and this is hurting our other keys.
+
+        * page/Page.cpp:
+        (WebCore::Page::logNavigation):
+
 2019-02-15  Ryosuke Niwa  <rniwa@webkit.org>
 
         Crash in the hit testing code via HTMLPlugInElement::isReplacementObscured()

diff --git a/Source/WebCore/page/Page.cpp b/Source/WebCore/page/Page.cpp
@@ -2369,7 +2369,7 @@ void Page::logNavigation(const Navigation& navigation)
     diagnosticLoggingClient().logDiagnosticMessage(DiagnosticLoggingKeys::navigationKey(), navigationDescription, ShouldSample::No);
 
     if (!navigation.domain.isEmpty())
-        diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::No);
+        diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::Yes);
 }
 
 void Page::mainFrameLoadStarted(const URL& destinationURL, FrameLoadType type)