Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
First step to fix hacked isReplaced: Rename isReplaced functions to i…
…sReplacedOrInlineBlock https://bugs.webkit.org/show_bug.cgi?id=235258 Reviewed by Alan Bujtas. The isReplaced function returns true for things that are not CSS replaced elements. That's confusing and not good. We want to straighten this out. In this first step, we rename the isReplaced and setReplaced functions to isReplacedOrInlineBlock and setReplacedOrInlineBlock. There are still functions with out arguments named "isReplaced", which we can deal with later. Other later clean-up and clarification could one day change what bits we store in RenderStyle and possibly even remove this function entirely. * accessibility/AccessibilityRenderObject.cpp: (WebCore::nextContinuation): * accessibility/atk/WebKitAccessible.cpp: (interfaceMaskFromObject): * css/CSSComputedStyleDeclaration.cpp: (WebCore::isNonReplacedInline): * dom/Node.cpp: (WebCore::Node::renderRect): * dom/Position.cpp: (WebCore::endsOfNodeAreVisuallyDistinctPositions): * editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate const): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate const): * layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForChild): * layout/integration/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::paint): * page/TextIndicator.cpp: (WebCore::hasNonInlineOrReplacedElements): * page/ios/FrameIOS.mm: (WebCore::Frame::renderRectForPoint const): * rendering/CaretRectComputation.cpp: (WebCore::computeCaretRectForBox): * rendering/LegacyInlineBox.cpp: (WebCore::LegacyInlineBox::adjustPosition): (WebCore::LegacyInlineBox::canAccommodateEllipsis const): * rendering/LegacyInlineFlowBox.cpp: (WebCore::LegacyInlineFlowBox::addToLine): (WebCore::LegacyInlineFlowBox::computeOverAnnotationAdjustment const): (WebCore::LegacyInlineFlowBox::computeUnderAnnotationAdjustment const): * rendering/LegacyInlineIterator.h: (WebCore::isIteratorTarget): * rendering/LegacyLineLayout.cpp: (WebCore::LegacyLineLayout::computeInlineDirectionPositionsForLine): (WebCore::LegacyLineLayout::layoutLineBoxes): * rendering/LegacyRootInlineBox.cpp: (WebCore::LegacyRootInlineBox::ascentAndDescentForBox const): (WebCore::LegacyRootInlineBox::verticalPositionForBox): (WebCore::LegacyRootInlineBox::includeLeadingForBox const): (WebCore::LegacyRootInlineBox::includeFontForBox const): (WebCore::LegacyRootInlineBox::includeGlyphsForBox const): (WebCore::LegacyRootInlineBox::includeInitialLetterForBox const): (WebCore::LegacyRootInlineBox::includeMarginForBox const): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::removePositionedObjectsIfNeeded): (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::simplifiedNormalFlowLayout): (WebCore::RenderBlock::paintChild): (WebCore::RenderBlock::positionForPoint): (WebCore::RenderBlock::lineHeight const): (WebCore::RenderBlock::baselinePosition const): (WebCore::RenderBlock::firstLineBlock const): (WebCore::findFirstLetterBlock): (WebCore::RenderBlock::getFirstLetter): * rendering/RenderBlock.h: * rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats): (WebCore::RenderBlockFlow::positionForPointWithInlineChildren): (WebCore::InlineMinMaxIterator::next): (WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const): * rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer const): (WebCore::RenderBox::positionLineBox): (WebCore::RenderBox::computeLogicalHeight const): (WebCore::RenderBox::shouldTreatChildAsReplacedInTableCells const): (WebCore::RenderBox::computePositionedLogicalWidth const): (WebCore::RenderBox::computePositionedLogicalHeight const): (WebCore::RenderBox::avoidsFloats const): (WebCore::RenderBox::isUnsplittableForPagination const): (WebCore::RenderBox::lineHeight const): (WebCore::RenderBox::baselinePosition const): * rendering/RenderBox.h: (WebCore::RenderBox::shouldComputeSizeAsReplaced const): * rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::canHaveBoxInfoInFragment const): * rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp): (WebCore::RenderDeprecatedFlexibleBox::clearLineClamp): * rendering/RenderElement.cpp: (WebCore::RenderElement::getLeadingCorner const): (WebCore::RenderElement::getTrailingCorner const): (WebCore::RenderElement::absoluteAnchorRect const): * rendering/RenderFullScreen.cpp: (WebCore::RenderFullScreen::RenderFullScreen): * rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild): * rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::RenderListMarker): * rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlockForPositionType): (WebCore::RenderObject::caretMaxOffset const): * rendering/RenderObject.h: (WebCore::RenderObject::hasIntrinsicAspectRatio const): (WebCore::RenderObject::isReplacedOrInlineBlock const): (WebCore::RenderObject::setReplacedOrInlineBlock): (WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields): (WebCore::RenderObject::isAtomicInlineLevelBox const): (WebCore::RenderObject::isReplaced const): Deleted. (WebCore::RenderObject::setReplaced): Deleted. * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): * rendering/RenderReplica.cpp: (WebCore::RenderReplica::RenderReplica): * rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::RenderRubyRun): * rendering/line/BreakingContext.h: (WebCore::BreakingContext::initializeForCurrentObject): (WebCore::BreakingContext::canBreakAtThisPosition): (WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded): * rendering/line/LineBreaker.cpp: (WebCore::LineBreaker::nextLineBreak): * rendering/updating/RenderTreeBuilderInline.cpp: (WebCore::nextContinuation): Renamed in all these places. Also added one FIXME for something Alan pointed out we'd like to do in the future. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::removeOnlyThisLayer): Removed unhelpful use of RenderLayer::reflection function just to find out whether the RenderLayer::reflectionLayer function will return null or not. * rendering/RenderLayer.h: Removed unneeded RenderLayer::reflection. * rendering/RenderLayerCompositor.cpp: Removed an unneeded include of RenderReplica.h. Canonical link: https://commits.webkit.org/246087@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
93c5106
commit cb9ab6a
Showing
39 changed files
with
234 additions
and
95 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.