Skip to content

Commit

Permalink
REGRESSION (270723@main): [ iOS17 macOS Debug ] TestWebKitAPI.Evaluat…
Browse files Browse the repository at this point in the history
…eJavaScript.JavaScriptInMissingFrameError is a consistent crash

https://bugs.webkit.org/show_bug.cgi?id=265070
rdar://118583083

Reviewed by Pascoe.

This API test is passing an invalid frame identifier to `evaluateJavaScript:inFrame:`, so we trip over
the debug assertion I added in 270723@main. We should just remove it for now.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendToWebPage):

Canonical link: https://commits.webkit.org/271225@main
  • Loading branch information
charliewolfe committed Nov 28, 2023
1 parent 7734fe5 commit cbb2b77
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions Source/WebKit/UIProcess/WebPageProxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13235,8 +13235,7 @@ void WebPageProxy::sendToWebPage(std::optional<FrameIdentifier> frameID, F&& sen
sendFunction(*remotePageProxy);
return;
}
} else
ASSERT_NOT_REACHED();
}
}
sendFunction(*this);
}
Expand Down

0 comments on commit cbb2b77

Please sign in to comment.