Skip to content
Permalink
Browse files
Global constructors exposed to service workers should go on ServiceWo…
…rkerGlobalScope interface

https://bugs.webkit.org/show_bug.cgi?id=178482

Reviewed by Sam Weinig.

Global constructors exposed to service workers should go on ServiceWorkerGlobalScope interface,
not the ServiceWorker interface.

* bindings/scripts/preprocess-idls.pl:

Canonical link: https://commits.webkit.org/194680@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cdumez committed Oct 18, 2017
1 parent 1cb0298 commit ccbfff19de7b0e9e845b624941fdfe1028b573a4
Showing 2 changed files with 13 additions and 1 deletion.
@@ -1,3 +1,15 @@
2017-10-18 Chris Dumez <cdumez@apple.com>

Global constructors exposed to service workers should go on ServiceWorkerGlobalScope interface
https://bugs.webkit.org/show_bug.cgi?id=178482

Reviewed by Sam Weinig.

Global constructors exposed to service workers should go on ServiceWorkerGlobalScope interface,
not the ServiceWorker interface.

* bindings/scripts/preprocess-idls.pl:

2017-10-17 Ryosuke Niwa <rniwa@webkit.org>

Add an argument indicating the type of insertion to Node::insertedInto
@@ -155,7 +155,7 @@
GeneratePartialInterface("DOMWindow", $windowConstructorsCode, $windowConstructorsFile);
GeneratePartialInterface("WorkerGlobalScope", $workerGlobalScopeConstructorsCode, $workerGlobalScopeConstructorsFile);
GeneratePartialInterface("DedicatedWorkerGlobalScope", $dedicatedWorkerGlobalScopeConstructorsCode, $dedicatedWorkerGlobalScopeConstructorsFile);
GeneratePartialInterface("ServiceWorker", $serviceWorkerGlobalScopeConstructorsCode, $serviceWorkerGlobalScopeConstructorsFile);
GeneratePartialInterface("ServiceWorkerGlobalScope", $serviceWorkerGlobalScopeConstructorsCode, $serviceWorkerGlobalScopeConstructorsFile);

# Resolves partial interfaces and implements dependencies.
foreach my $idlFile (sort keys %supplementalDependencies) {

0 comments on commit ccbfff1

Please sign in to comment.