-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cherry-pick 1eb4751. rdar://problem/88406961
Remove WebArchiveDebugMode https://bugs.webkit.org/show_bug.cgi?id=245488 <rdar://problem/88406961> Reviewed by Geoffrey Garen. Original patch by: Kate Cheney <katherine_cheney@apple.com> Remove use case of WebArchiveDebugMode and deprecate it now that it is no longer in use. Add a new temporary flag WebArchiveTestMode that is more aptly named and will maintain existing behavior for internal tests temporarily. In addition, for clarity annotate resource URLs in WebArchive with "webarchive+" prefix, but avoid breaking web content that transits the pasteboard. If a requested resource has that scheme prefix, then strip it. * LayoutTests/platform/wk2/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt: * LayoutTests/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt: * Source/WTF/Scripts/Preferences/WebPreferences.yaml: * Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm: (WebCore::extractMarkupAndArchive): * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingRemoteArchive const): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::scheduleArchiveLoad): * Source/WebCore/loader/DocumentLoader.h: * Source/WebCore/loader/ResourceLoader.cpp: (WebCore::ResourceLoader::start): * Source/WebCore/loader/archive/ArchiveResourceCollection.cpp: (WebCore::ArchiveResourceCollection::addResource): (WebCore::ArchiveResourceCollection::archiveResourceForURL): * Source/WebCore/loader/archive/ArchiveResourceCollection.h: * Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createResource): (WebCore::LegacyWebArchive::create): (WebCore::LegacyWebArchive::extract): * Source/WebCore/loader/archive/cf/LegacyWebArchive.h: * Source/WebCore/page/SecurityOrigin.cpp: (WebCore::shouldTreatAsOpaqueOrigin): * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetWebArchiveTestingModeEnabled): (WKPreferencesGetWebArchiveTestingModeEnabled): (WKPreferencesSetWebArchiveDebugModeEnabled): (WKPreferencesGetWebArchiveDebugModeEnabled): * Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h: * Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _setWebArchiveTestingModeEnabled:]): (-[WKPreferences _webArchiveTestingModeEnabled]): (-[WKPreferences _setWebArchiveDebugModeEnabled:]): (-[WKPreferences _webArchiveDebugModeEnabled]): * Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h: * Source/WebKitLegacy/mac/WebView/WebView.mm: (+[WebView _canHandleRequest:forMainFrame:]): * Tools/TestWebKitAPI/Tests/mac/LoadWebArchive.mm: (TestWebKitAPI::constructArchive): (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/255705@main Canonical link: https://commits.webkit.org/252432.795@safari-7614-branch
- Loading branch information
Showing
18 changed files
with
167 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.