Skip to content

Commit

Permalink
Remove deadcode from SVGResourcesCache::clientStyleChanged
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=253403

Reviewed by Nikolas Zimmermann.

Remove code that is never ran due to clientStyleChanged
only being called by SVG renderers which are only
associated with SVGElements, making the if statement
always false.

* Source/WebCore/rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):

Canonical link: https://commits.webkit.org/269518@main
  • Loading branch information
rwlbuis authored and nikolaszimmermann committed Oct 19, 2023
1 parent 9c2a7fe commit cd8b6c2
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions Source/WebCore/rendering/svg/SVGResourcesCache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ static inline bool rendererCanHaveResources(RenderObject& renderer)

void SVGResourcesCache::clientStyleChanged(RenderElement& renderer, StyleDifference diff, const RenderStyle* oldStyle, const RenderStyle& newStyle)
{
ASSERT(!renderer.element() || renderer.element()->isSVGElement());

if (!renderer.parent())
return;

Expand Down Expand Up @@ -165,9 +167,6 @@ void SVGResourcesCache::clientStyleChanged(RenderElement& renderer, StyleDiffere
}

RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer, false);

if (renderer.element() && !renderer.element()->isSVGElement())
renderer.element()->invalidateStyle();
}

void SVGResourcesCache::clientWasAddedToTree(RenderObject& renderer)
Expand Down

0 comments on commit cd8b6c2

Please sign in to comment.