Skip to content

Commit

Permalink
[JSC] Skip some tests specifically for $memoryLimited and $isSIMDPlat…
Browse files Browse the repository at this point in the history
…form

https://bugs.webkit.org/show_bug.cgi?id=269730

Unreviewed test gardening.

We want some tests to be skipped for $memoryLimited and $isSIMDPlatform
specifically (as opposed to for ARM) for classification reasons.

Also unskips JSTests/wasm/function-tests/trap-store-shared.js for
armv7 (no longer failing).

Also skips JSTests/stress/sampling-profiler-microtasks.js again
on armv7 because it fails in non-debug builds.

* JSTests/microbenchmarks/get-private-name.js:
* JSTests/stress/bigdecimal-identifiers-fail-on-oom.js:
* JSTests/stress/sampling-profiler-microtasks.js:
* JSTests/stress/sampling-profiler-richards.js:
* JSTests/wasm/function-tests/trap-store-shared.js:
* JSTests/wasm/v8/liftoff-simd-params.js:
* JSTests/wasm/v8/multi-value-simd.js:
* JSTests/wasm/v8/simd-call.js:
* JSTests/wasm/v8/simd-errors.js:
* JSTests/wasm/v8/simd-globals.js:
* JSTests/wasm/v8/simd-i64x2-mul.js:

Canonical link: https://commits.webkit.org/274989@main
  • Loading branch information
Max Rottenkolber authored and jjgriego committed Feb 19, 2024
1 parent b024ab1 commit d061370
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion JSTests/microbenchmarks/get-private-name.js
@@ -1,5 +1,5 @@
//@ $skipModes << :lockdown if $buildType == "debug"
//@ skip if $architecture == "arm" and !$cloop
//@ skip if $memoryLimited

function assert(b, m = "Assertion failed") {
if (!b)
Expand Down
2 changes: 1 addition & 1 deletion JSTests/stress/bigdecimal-identifiers-fail-on-oom.js
@@ -1,4 +1,4 @@
//@ skip if $architecture == "arm" or $memoryLimited
//@ skip if $memoryLimited

function foo() {
let m = new WebAssembly.Memory({initial: 1000});
Expand Down
2 changes: 1 addition & 1 deletion JSTests/stress/sampling-profiler-richards.js
@@ -1,6 +1,6 @@
//@ skip if not $jitTests
//@ skip if $architecture == "x86"
//@ skip if $architecture == "arm"
//@ skip if $memoryLimited
//@ runDefault("--collectContinuously=1", "--useSamplingProfiler=1", "--collectExtraSamplingProfilerData=1")

"use strict";
Expand Down
2 changes: 1 addition & 1 deletion JSTests/wasm/function-tests/trap-store-shared.js
@@ -1,4 +1,4 @@
//@ skip if $architecture != "arm64" && $architecture != "x86_64"
//@ skip if $architecture != "arm64" && $architecture != "x86_64" && $architecture != "arm"
import Builder from '../Builder.js'
import * as assert from '../assert.js'

Expand Down
2 changes: 1 addition & 1 deletion JSTests/wasm/v8/liftoff-simd-params.js
@@ -1,5 +1,5 @@
//@ requireOptions("--useWebAssemblySIMD=1")
//@ skip if $architecture != "arm64" && $architecture != "x86_64"
//@ skip if !$isSIMDPlatform
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
2 changes: 1 addition & 1 deletion JSTests/wasm/v8/multi-value-simd.js
@@ -1,5 +1,5 @@
//@ requireOptions("--useWebAssemblySIMD=1")
//@ skip if $architecture != "arm64" && $architecture != "x86_64"
//@ skip if !$isSIMDPlatform
// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
2 changes: 1 addition & 1 deletion JSTests/wasm/v8/simd-call.js
@@ -1,5 +1,5 @@
//@ requireOptions("--useWebAssemblySIMD=1")
//@ skip if $architecture != "arm64" && $architecture != "x86_64"
//@ skip if !$isSIMDPlatform
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
2 changes: 1 addition & 1 deletion JSTests/wasm/v8/simd-errors.js
@@ -1,5 +1,5 @@
//@ requireOptions("--useWebAssemblySIMD=1")
//@ skip if $architecture != "arm64" && $architecture != "x86_64"
//@ skip if !$isSIMDPlatform
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
2 changes: 1 addition & 1 deletion JSTests/wasm/v8/simd-globals.js
@@ -1,5 +1,5 @@
//@ requireOptions("--useWebAssemblySIMD=1")
//@ skip if $architecture != "arm64" && $architecture != "x86_64"
//@ skip if !$isSIMDPlatform
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down
2 changes: 1 addition & 1 deletion JSTests/wasm/v8/simd-i64x2-mul.js
@@ -1,5 +1,5 @@
//@ requireOptions("--useWebAssemblySIMD=1")
//@ skip if $architecture != "arm64" && $architecture != "x86_64"
//@ skip if !$isSIMDPlatform
// Copyright 2021 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Expand Down

0 comments on commit d061370

Please sign in to comment.