[Digital Identity]: pref name should reflect new API name

https://bugs.webkit.org/show_bug.cgi?id=269163 rdar://122740257 Reviewed by Chris Dumez. Renamed DigitalCredentialsEnabled to DigitalIdentityEnable. * LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https-expected.txt: Renamed from LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnabled.https-expected.txt. * LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https.html: Renamed from LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnabled.https.html. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.idl: * Source/WebCore/Modules/credentialmanagement/DigitalIdentity.idl: Canonical link: https://commits.webkit.org/274470@main
WebKit · Feb 12, 2024 · d44a5a2 · d44a5a2
1 parent 48efea4
commit d44a5a2
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/...italCredentialsEnabled.https-expected.txt → ...tDigitalIdentityEnable.https-expected.txt b/...italCredentialsEnabled.https-expected.txt → ...tDigitalIdentityEnable.https-expected.txt
diff --git a/...t/setDigitalCredentialsEnabled.https.html → ...ement/setDigitalIdentityEnable.https.html b/...t/setDigitalCredentialsEnabled.https.html → ...ement/setDigitalIdentityEnable.https.html
@@ -2,8 +2,8 @@
 <html>
     <head>
         <title>
-            Check that Credential Management parts of the API are not exposed by
-            default
+            Check that parts of the Digital Identity API are not exposed by
+            setting
         </title>
     </head>
     <script>
@@ -20,7 +20,7 @@
             );
         }
 
-        window.internals.settings.setDigitalCredentialsEnabled(true);
+        window.internals.settings.setDigitalIdentityEnabled(true);
 
         async function checkIFrame() {
             const iframeWin = document.querySelector("iframe").contentWindow;

diff --git a/Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml b/Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
@@ -2393,12 +2393,12 @@ DiagnosticLoggingEnabled:
     WebCore:
       default: false
 
-DigitalCredentialsEnabled:
+DigitalIdentityEnabled:
   type: bool
   status: unstable
   category: dom
-  humanReadableName: "Digital Credentials API"
-  humanReadableDescription: "Enable the experimental Digital Credentials API"
+  humanReadableName: "Digital Identity API"
+  humanReadableDescription: "Enable the experimental Digital Identity API"
   defaultValue:
     WebKitLegacy:
       default: false

diff --git a/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.idl b/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.idl
@@ -34,5 +34,5 @@
     Promise<BasicCredential> store(BasicCredential credential);
     Promise<BasicCredential?> create(optional CredentialCreationOptions options);
     Promise<undefined> preventSilentAccess();
-    [EnabledBySetting=DigitalCredentialsEnabled] Promise<DigitalIdentity> requestIdentity(DigitalCredentialRequestOptions options);
+    [EnabledBySetting=DigitalIdentityEnabled] Promise<DigitalIdentity> requestIdentity(DigitalCredentialRequestOptions options);
 };
diff --git a/Source/WebCore/Modules/credentialmanagement/DigitalIdentity.idl b/Source/WebCore/Modules/credentialmanagement/DigitalIdentity.idl
@@ -26,7 +26,7 @@
 [
     Exposed=Window,
     SecureContext,
-    EnabledBySetting=DigitalCredentialsEnabled,
+    EnabledBySetting=DigitalIdentityEnabled,
     Conditional=WEB_AUTHN,
 ] interface DigitalIdentity : BasicCredential {
     [SameObject] readonly attribute ArrayBuffer data;