Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge r220694 - [GTK][WPE] Avoid emitting WebKitFaviconDatabase::favi…
…con-changed multiple times while setting an icon https://bugs.webkit.org/show_bug.cgi?id=175531 Reviewed by Michael Catanzaro. When webkitFaviconDatabaseSetIconForPageURL() is called, both setIconURLForPageURL() and setIconDataForIconURL() might notify the client, which ends up emitting the WebKitFaviconDatabase::favicon-changed signal and calling webkitFaviconDatabaseSetIconURLForPageURL(). Both things are already done by webkitFaviconDatabaseSetIconForPageURL() itself, so we can just ignore the client notification while setting a new icon. * UIProcess/API/glib/WebKitFaviconDatabase.cpp: (webkitFaviconDatabaseSetIconURLForPageURL): Return early if isSettingIcon is true. (webkitFaviconDatabaseSetIconForPageURL): Set isSettingIcon to true for the scope.
- Loading branch information
1 parent
7844f46
commit d4abc27
Showing
2 changed files
with
25 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters