Skip to content

Commit

Permalink
REGRESSION(266644@main): [wk2] http/tests/security/referrer-policy-he…
Browse files Browse the repository at this point in the history
…ader.html is a flaky text failure, crash

https://bugs.webkit.org/show_bug.cgi?id=260632
rdar://114349670

Reviewed by Brent Fulgham.

This test wasn't waiting for completion of the iframe loads in order to
determine what the referrer was given a referrer policy. There were two
problems: one was I mistakenly added an extra call to runTests so we
were running synchronously once. The other problem was we weren't
telling the test runner to wait until we were finished loading the
iframe and receiving the messages from it with the results. The former
led to flaky results and the latter led to flaky crashes.

* LayoutTests/http/tests/security/referrer-policy-header.html:
* LayoutTests/platform/wk2/TestExpectations:

Canonical link: https://commits.webkit.org/267241@main
  • Loading branch information
rreno committed Aug 24, 2023
1 parent 8987771 commit d4d875b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 3 additions & 2 deletions LayoutTests/http/tests/security/referrer-policy-header.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@
<script>
description("Tests support for Referrer-Policy HTTP header.");
jsTestIsAsync = true;
runTests(false);
if (window.testRunner)
if (window.testRunner) {
testRunner.waitUntilDone();
testRunner.setStatisticsShouldDowngradeReferrer(false, async () => { await runTests(false /* multipart */); });
}
</script>
</body>
</html>
2 changes: 0 additions & 2 deletions LayoutTests/platform/wk2/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,4 @@ webkit.org/b/259409 imported/w3c/web-platform-tests/cookies/partitioned-cookies/

webkit.org/b/259482 fast/media/managed-media-source-open-crash.html [ Pass Failure ]

webkit.org/b/260632 http/tests/security/referrer-policy-header.html [ Pass Failure Crash ]

webkit.org/b/260640 [ Release arm64 ] editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html [ Pass Failure ]

0 comments on commit d4d875b

Please sign in to comment.