Skip to content

Commit

Permalink
[CMake] Regenerate bindings when UnifiedWebPreferences is modified
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=264156

Reviewed by Don Olmstead.

When a setting is removed from UnifiedWebPreferences the output of
the generated files may change if an IDL file uses EnabledBySetting.

Ideally this would be tracked per IDL file but that isn't how the
generator currently works.

* Source/WebCore/WebCoreMacros.cmake:

Canonical link: https://commits.webkit.org/276276@main
  • Loading branch information
TingPing committed Mar 18, 2024
1 parent 0be7669 commit d679abb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Source/WebCore/WebCoreMacros.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ function(GENERATE_BINDINGS target)
# Changing enabled features should trigger recompiling all IDL files
# because some of them use #if.
${CMAKE_BINARY_DIR}/cmakeconfig.h
# Settings can be removed also which requires regeneration.
${WTF_WEB_PREFERENCES}
)
if (EXISTS ${WEBCORE_DIR}/bindings/scripts/CodeGenerator${arg_GENERATOR}.pm)
list(APPEND common_generator_dependencies ${WEBCORE_DIR}/bindings/scripts/CodeGenerator${arg_GENERATOR}.pm)
Expand Down

0 comments on commit d679abb

Please sign in to comment.