Skip to content

Commit

Permalink
DigitalCredential's response attribute was renamed to data
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=268139
rdar://121639016

Reviewed by Tim Nguyen.

Renames DigitalCredential's "response" attribute to "data" to match the spec.
WICG/digital-credentials#57

* Source/WebCore/Modules/credentialmanagement/DigitalCredential.cpp:
(WebCore::DigitalCredential::create):
(WebCore::DigitalCredential::DigitalCredential):
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.h:
(WebCore::DigitalCredential::data const):
(WebCore::DigitalCredential::response const): Deleted.
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl:

Canonical link: https://commits.webkit.org/273595@main
  • Loading branch information
marcoscaceres committed Jan 27, 2024
1 parent 0b96465 commit d686b02
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@

namespace WebCore {

Ref<DigitalCredential> DigitalCredential::create(Ref<ArrayBuffer>&& response)
Ref<DigitalCredential> DigitalCredential::create(Ref<ArrayBuffer>&& data)
{
return adoptRef(*new DigitalCredential(WTFMove(response)));
return adoptRef(*new DigitalCredential(WTFMove(data)));
}

DigitalCredential::~DigitalCredential() = default;

DigitalCredential::DigitalCredential(Ref<ArrayBuffer>&& response)
: m_response(WTFMove(response))
DigitalCredential::DigitalCredential(Ref<ArrayBuffer>&& data)
: m_data(WTFMove(data))
{
}

Expand Down
10 changes: 5 additions & 5 deletions Source/WebCore/Modules/credentialmanagement/DigitalCredential.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,19 @@ using DigitalCredentialPromise = DOMPromiseDeferred<IDLInterface<DigitalCredenti

class DigitalCredential : public RefCounted<DigitalCredential> {
public:
static Ref<DigitalCredential> create(Ref<ArrayBuffer>&& response);
static Ref<DigitalCredential> create(Ref<ArrayBuffer>&& data);

virtual ~DigitalCredential();

ArrayBuffer* response() const
ArrayBuffer* data() const
{
return m_response.get();
return m_data.get();
};

private:
DigitalCredential(Ref<ArrayBuffer>&& response);
DigitalCredential(Ref<ArrayBuffer>&& data);

RefPtr<ArrayBuffer> m_response;
RefPtr<ArrayBuffer> m_data;
};

} // namespace WebCore
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@
Exposed=Window,
SecureContext,
] interface DigitalCredential {
[SameObject] readonly attribute ArrayBuffer response;
[SameObject] readonly attribute ArrayBuffer data;
};

0 comments on commit d686b02

Please sign in to comment.