-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Win] editing/selection/caret-rtl-right.html is randomly failing
https://bugs.webkit.org/show_bug.cgi?id=262460 Reviewed by Don Olmstead. The following tests were randomly failing becuase a click sometimes dispatched a double-click event. editing/deleting/smart-delete-001.html editing/deleting/smart-delete-003.html editing/deleting/smart-delete-004.html editing/selection/5057506.html editing/selection/caret-ltr-right.html editing/selection/caret-rtl-right.html Reset the mouse position after the previous test not to dispatch a fake double-click event for a click in the next page. * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/editing/deleting/smart-delete-004-expected.txt: * Tools/WebKitTestRunner/win/TestControllerWin.cpp: Canonical link: https://commits.webkit.org/269217@main
- Loading branch information
Showing
3 changed files
with
11 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 8 additions & 4 deletions
12
LayoutTests/platform/wincairo/editing/deleting/smart-delete-004-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,20 @@ | ||
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 3 of DIV > BODY > HTML > #document | ||
EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification | ||
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification | ||
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE | ||
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE | ||
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification | ||
EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document | ||
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE | ||
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE | ||
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification | ||
EDITING DELEGATE: shouldDeleteDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document | ||
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification | ||
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification | ||
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 0 of #text > DIV > BODY > HTML > #document toDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE | ||
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification | ||
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification | ||
This tests deleting a selection created with a word granularity. To run it manually, double click on 'bar' and hit forward delete. You should see 'foo baz'. | ||
|
||
Expected Results: | ||
The second word and the space before the second word should be deleted. It should like this this: | ||
foo baz | ||
|
||
foo baz | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters