Merge r163435 - MediaPlayerPrivateGStreamerBase should have virtual d…

…estructor https://bugs.webkit.org/show_bug.cgi?id=128238 Reviewed by Carlos Garcia Campos. MediaPlayerPrivateGStreamer inherit MediaPlayerPrivateGStreamerBase. So MediaPlayerPrivateGStreamerBase should have virtual destructor. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Made destructor as virtual.
WebKit · Feb 10, 2014 · d7ab737 · d7ab737
1 parent aea46d5
commit d7ab737
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2014-02-05  Ryuan Choi  <ryuan.choi@samsung.com>
+
+        MediaPlayerPrivateGStreamerBase should have virtual destructor
+        https://bugs.webkit.org/show_bug.cgi?id=128238
+
+        Reviewed by Carlos Garcia Campos.
+
+        MediaPlayerPrivateGStreamer inherit MediaPlayerPrivateGStreamerBase.
+        So MediaPlayerPrivateGStreamerBase should have virtual destructor.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Made destructor as virtual.
+
 2014-02-03  Radu Stavila  <stavila@adobe.com>
 
         REGRESSION (r163018): Can’t scroll in <select> lists

diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h
@@ -54,7 +54,7 @@ class MediaPlayerPrivateGStreamerBase : public MediaPlayerPrivateInterface
 {
 
 public:
-    ~MediaPlayerPrivateGStreamerBase();
+    virtual ~MediaPlayerPrivateGStreamerBase();
 
     IntSize naturalSize() const;