Skip to content

Commit

Permalink
Merge r221800 - Uncaught Exception: TypeError: this._heapSnapshot.add…
Browse files Browse the repository at this point in the history
…EventListener is not a function.

https://bugs.webkit.org/show_bug.cgi?id=176633

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-09-08
Reviewed by Michael Saboff.

* UserInterface/Proxies/HeapSnapshotDiffProxy.js:
(WI.HeapSnapshotDiffProxy):
This class has listeners of another object's events. It should extend WI.Object.
  • Loading branch information
JosephPecoraro authored and carlosgcampos committed Jan 10, 2018
1 parent 66e9a0d commit d85be29
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
11 changes: 11 additions & 0 deletions Source/WebInspectorUI/ChangeLog
@@ -1,3 +1,14 @@
2017-09-08 Joseph Pecoraro <pecoraro@apple.com>

Uncaught Exception: TypeError: this._heapSnapshot.addEventListener is not a function.
https://bugs.webkit.org/show_bug.cgi?id=176633

Reviewed by Michael Saboff.

* UserInterface/Proxies/HeapSnapshotDiffProxy.js:
(WI.HeapSnapshotDiffProxy):
This class has listeners of another object's events. It should extend WI.Object.

2017-08-14 Simon Fraser <simon.fraser@apple.com>

Remove Proximity Events and related code
Expand Down
Expand Up @@ -23,10 +23,12 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/

WI.HeapSnapshotDiffProxy = class HeapSnapshotDiffProxy
WI.HeapSnapshotDiffProxy = class HeapSnapshotDiffProxy extends WI.Object
{
constructor(snapshotDiffObjectId, snapshot1, snapshot2, totalSize, totalObjectCount, categories)
{
super();

this._proxyObjectId = snapshotDiffObjectId;

console.assert(snapshot1 instanceof WI.HeapSnapshotProxy);
Expand Down

0 comments on commit d85be29

Please sign in to comment.