Skip to content

Commit

Permalink
[JSC] Disable JIT for Windows
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=254478

Reviewed by Carlos Alberto Lopez Perez.

Windows JSC JIT is crashing now. <https://webkit.org/b/273854>
Disabled JIT for Windows temporarily.

* LayoutTests/platform/wincairo/TestExpectations:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:

Canonical link: https://commits.webkit.org/278545@main
  • Loading branch information
fujii committed May 9, 2024
1 parent 5ab3ad6 commit da80566
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 7 deletions.
16 changes: 13 additions & 3 deletions LayoutTests/platform/wincairo/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -3192,9 +3192,19 @@ webkit.org/b/263926 fast/animation/request-animation-frame-throttling-detached-i

webkit.org/b/261308 imported/w3c/web-platform-tests/cookies/path/default.html [ Pass Failure ]

imported/w3c/web-platform-tests/wasm/serialization/module/nested-worker-success.any.worker.html [ Skip ] # Failure
imported/w3c/web-platform-tests/wasm/serialization/module/serialization-via-notifications-api.any.html [ Skip ] # Failure
imported/w3c/web-platform-tests/wasm/serialization/module/serialization-via-notifications-api.any.worker.html [ Skip ] # Failure
# Needs JIT
js/slow-stress [ Skip ]

# Web Assembly is't supported yet
imported/w3c/web-platform-tests/wasm [ Skip ]
js/dom/webassembly-memory-normal-fail.html [ Skip ]
js/dom/webassembly-memory-shared-basic.html [ Skip ]
js/dom/webassembly-memory-shared-fail.html [ Skip ]
storage/indexeddb/wasm-exceptions.html [ Skip ]
wasm [ Skip ]
webgl/2.0.y/conformance2/wasm [ Skip ]
workers/wasm-long-compile.html [ Skip ]
workers/wasm-mem-post-message.html [ Skip ]

workers/wasm-hashset-many-2.html [ Skip ] # Timeout
workers/wasm-hashset-many.html [ Skip ] # Timeout
Expand Down
3 changes: 0 additions & 3 deletions Source/cmake/OptionsWin.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,6 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_DATETIMELOCAL PUBLIC OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_MONTH PUBLIC OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_TIME PUBLIC OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_WEEK PUBLIC OFF)
if (${WTF_CPU_X86})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_JIT PUBLIC OFF)
endif ()
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LAYOUT_TESTS PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MATHML PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE PUBLIC OFF)
Expand Down
8 changes: 7 additions & 1 deletion Source/cmake/WebKitFeatures.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,13 @@ option(USE_64KB_PAGE_BLOCK "Support 64 KB userspace page size (reduces security
macro(WEBKIT_OPTION_BEGIN)
set(_SETTING_WEBKIT_OPTIONS TRUE)

if (USE_64KB_PAGE_BLOCK)
if (WTF_OS_WINDOWS)
set(ENABLE_JIT_DEFAULT OFF)
set(ENABLE_FTL_DEFAULT OFF)
set(USE_SYSTEM_MALLOC_DEFAULT ON)
set(ENABLE_C_LOOP_DEFAULT OFF)
set(ENABLE_SAMPLING_PROFILER_DEFAULT OFF)
elseif (USE_64KB_PAGE_BLOCK)
set(ENABLE_JIT_DEFAULT OFF)
set(ENABLE_FTL_DEFAULT OFF)
set(USE_SYSTEM_MALLOC_DEFAULT ON)
Expand Down

0 comments on commit da80566

Please sign in to comment.