Skip to content

Commit

Permalink
REGRESSION(r275765) When ignoring HSTS, sometimes loads fail
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=226670
<rdar://problem/78066692>

Patch by Alex Christensen <achristensen@webkit.org> on 2021-06-04
Reviewed by Chris Dumez.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(setIgnoreHSTS):
Use the value passed in to the function instead of always false.

Canonical link: https://commits.webkit.org/238516@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Alex Christensen authored and webkit-commit-queue committed Jun 5, 2021
1 parent 3194bf4 commit dbfad4d
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
12 changes: 12 additions & 0 deletions Source/WebKit/ChangeLog
@@ -1,3 +1,15 @@
2021-06-04 Alex Christensen <achristensen@webkit.org>

REGRESSION(r275765) When ignoring HSTS, sometimes loads fail
https://bugs.webkit.org/show_bug.cgi?id=226670
<rdar://problem/78066692>

Reviewed by Chris Dumez.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(setIgnoreHSTS):
Use the value passed in to the function instead of always false.

2021-06-04 Chris Dumez <cdumez@apple.com>

Use Vector<uint8_t> instead of Vector<char> to store bytes in SharedBuffer
Expand Down
2 changes: 1 addition & 1 deletion Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Expand Up @@ -511,7 +511,7 @@ static void setIgnoreHSTS(NSMutableURLRequest *request, bool ignoreHSTS)
static void setIgnoreHSTS(RetainPtr<NSURLRequest>& request, bool shouldIgnoreHSTS)
{
auto mutableRequest = adoptNS([request mutableCopy]);
setIgnoreHSTS(mutableRequest.get(), false);
setIgnoreHSTS(mutableRequest.get(), shouldIgnoreHSTS);
request = mutableRequest;
}

Expand Down

0 comments on commit dbfad4d

Please sign in to comment.