Merge r241590 - [GStreamer] Simplify GObject class name check

https://bugs.webkit.org/show_bug.cgi?id=194537 Patch by Philippe Normand <pnormand@igalia.com> on 2019-02-15 Reviewed by Michael Catanzaro. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback): Use G_OBJECT_TYPE_NAME() to filter out uridecodebin child elements.
WebKit · Feb 18, 2019 · dc5daa7 · dc5daa7
1 parent 0f5acfc
commit dc5daa7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2019-02-15  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] Simplify GObject class name check
+        https://bugs.webkit.org/show_bug.cgi?id=194537
+
+        Reviewed by Michael Catanzaro.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback):
+        Use G_OBJECT_TYPE_NAME() to filter out uridecodebin child
+        elements.
+
 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         Refactor EditingStyle::textDirection to return an Optional<WritingDirection> instead of a bool

diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
@@ -1752,7 +1752,7 @@ void MediaPlayerPrivateGStreamer::sourceSetupCallback(MediaPlayerPrivateGStreame
 
 void MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback(GstBin* bin, GstElement* element, MediaPlayerPrivateGStreamer* player)
 {
-    if (g_strcmp0(G_OBJECT_CLASS_NAME(G_OBJECT_GET_CLASS(G_OBJECT(element))), "GstDownloadBuffer"))
+    if (g_strcmp0(G_OBJECT_TYPE_NAME(element), "GstDownloadBuffer"))
         return;
 
     player->m_downloadBuffer = element;