-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Out-of-flow line break box does not initiate render layer
https://bugs.webkit.org/show_bug.cgi?id=267270 rdar://120662818 Reviewed by Antti Koivisto. 1. Let's not assume that an out-of-flow box is a type of RenderBox (e.g. line break) 2. Not all out-of-flow positioned boxes trigger layers. * LayoutTests/fast/text/align-line-shift-crash-with-positioned-line-break-expected.txt: Added. * LayoutTests/fast/text/align-line-shift-crash-with-positioned-line-break.html: Added. * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::shiftLinesBy): Originally-landed-as: 272448.26@safari-7618-branch (6eed834). rdar://124557101 Canonical link: https://commits.webkit.org/276181@main
- Loading branch information
1 parent
6f20a05
commit dcc6d93
Showing
3 changed files
with
18 additions
and
2 deletions.
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
LayoutTests/fast/text/align-line-shift-crash-with-positioned-line-break-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
|
||
PASS if no crash or assert |
13 changes: 13 additions & 0 deletions
13
LayoutTests/fast/text/align-line-shift-crash-with-positioned-line-break.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<style> | ||
br { | ||
position: fixed; | ||
} | ||
body { | ||
-webkit-align-content: flex-end; | ||
} | ||
</style><br> | ||
<div>PASS if no crash or assert</div> | ||
<script> | ||
if (window.testRunner) | ||
testRunner.dumpAsText(); | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters