[web-animations] remove the IterationCompositeEnabled flag

https://bugs.webkit.org/show_bug.cgi?id=265437 Reviewed by Tim Nguyen. This flag was enabled by default a year ago exactly and is ripe for removal. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::create): * Source/WebCore/animation/KeyframeEffect.idl: Canonical link: https://commits.webkit.org/271195@main
WebKit · Nov 28, 2023 · ddee4b2 · ddee4b2
1 parent 99f5a39
commit ddee4b2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 18 deletions.
diff --git a/Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml b/Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
@@ -7165,20 +7165,6 @@ WebAnimationsCustomFrameRateEnabled:
     WebCore:
       default: false
 
-WebAnimationsIterationCompositeEnabled:
-  type: bool
-  status: stable
-  category: animation
-  humanReadableName: "Web Animations iteration composite"
-  humanReadableDescription: "Support for the KeyframeEffect.iterationComposite property"
-  defaultValue:
-    WebKitLegacy:
-      default: true
-    WebKit:
-      default: true
-    WebCore:
-      default: true
-
 WebArchiveDebugModeEnabled:
   type: bool
   status: embedder

diff --git a/Source/WebCore/animation/KeyframeEffect.cpp b/Source/WebCore/animation/KeyframeEffect.cpp
@@ -556,9 +556,7 @@ ExceptionOr<Ref<KeyframeEffect>> KeyframeEffect::create(JSGlobalObject& lexicalG
             };
 
             keyframeEffect->setComposite(keyframeEffectOptions.composite);
-
-            if (document.settings().webAnimationsIterationCompositeEnabled())
-                keyframeEffect->setIterationComposite(keyframeEffectOptions.iterationComposite);
+            keyframeEffect->setIterationComposite(keyframeEffectOptions.iterationComposite);
         }
         auto updateTimingResult = keyframeEffect->updateTiming(timing);
         if (updateTimingResult.hasException())

diff --git a/Source/WebCore/animation/KeyframeEffect.idl b/Source/WebCore/animation/KeyframeEffect.idl
@@ -34,7 +34,7 @@ typedef USVString CSSOMString;
 
     attribute Element? target;
     attribute CSSOMString? pseudoElement;
-    [EnabledBySetting=WebAnimationsIterationCompositeEnabled] attribute IterationCompositeOperation iterationComposite;
+    attribute IterationCompositeOperation iterationComposite;
     [ImplementedAs=bindingsComposite] attribute CompositeOperation composite;
     [Custom] sequence<object> getKeyframes();
     [CallWith=CurrentGlobalObject&CurrentDocument, ImplementedAs=setBindingsKeyframes] undefined setKeyframes(object? keyframes);