Skip to content

Commit

Permalink
visionOS: Fix the build for all BaseExtension-derived targets
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=262414
rdar://116261778

Reviewed by Dean Jackson.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
Don't specify SUPPORTED_PLATFORMS here because:

A) we get it via inheritance

B) this comes *after* we import LocalOverrides (unlike Base.xcconfig, which is *before*),
and thus overrides LocalOverrides' overrides, causing LocalOverrides to be unable to add
the visionOS platform to SUPPORTED_PLATFORMS, and causing Xcode to choose a different
platform to build for, at random (and, notably, one which it did not build the rest of WebKit for).

Canonical link: https://commits.webkit.org/268679@main
  • Loading branch information
hortont424 committed Sep 30, 2023
1 parent b4da3e2 commit de3b4d4
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Source/WebKit/Configurations/BaseExtension.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ SWIFT_VERSION = 5.0;
SWIFT_OPTIMIZATION_LEVEL = -O;
SWIFT_OPTIMIZATION_LEVEL[config=Debug] = -Onone;
PRODUCT_NAME = $(TARGET_NAME);
SUPPORTED_PLATFORMS = appletvos appletvsimulator iphoneos iphonesimulator macosx watchos watchsimulator;
SUPPORTS_MACCATALYST = NO;
SUPPORTS_MAC_DESIGNED_FOR_IPHONE_IPAD = NO;
TARGETED_DEVICE_FAMILY = 1,2;
Expand Down

0 comments on commit de3b4d4

Please sign in to comment.