REGRESSION(274824@main): [MSE][GStreamer][Debug] SHOULD NEVER BE REAC…

…HED in MediaPlayerPrivateGStreamerMSE::buffered() https://bugs.webkit.org/show_bug.cgi?id=269988 Reviewed by Philippe Normand. `MediaPlayerPrivateGStreamerMSE` should overload `extraMemoryCost()` and return 0, as `MediaPlayerPrivateMediaSourceAVFObjC` already does. * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp: (WebCore::MediaPlayerPrivateGStreamerMSE::extraMemoryCost const): * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h: Canonical link: https://commits.webkit.org/275317@main
WebKit · Feb 26, 2024 · df3b091 · df3b091
1 parent 85958c8
commit df3b091
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp b/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
@@ -322,6 +322,11 @@ void MediaPlayerPrivateGStreamerMSE::sourceSetup(GstElement* sourceElement)
         webKitMediaSrcEmitStreams(WEBKIT_MEDIA_SRC(m_source.get()), m_tracks);
 }
 
+size_t MediaPlayerPrivateGStreamerMSE::extraMemoryCost() const
+{
+    return 0;
+}
+
 void MediaPlayerPrivateGStreamerMSE::updateStates()
 {
     bool isSeeking = isPipelineSeeking();

diff --git a/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h b/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h
@@ -99,6 +99,8 @@ class MediaPlayerPrivateGStreamerMSE : public MediaPlayerPrivateGStreamer {
     friend class SourceBufferPrivateGStreamer;
     friend class MediaSourcePrivateGStreamer;
 
+    size_t extraMemoryCost() const override;
+
     void updateStates() override;
 
     // FIXME: Implement videoPlaybackQualityMetrics.