Skip to content

Commit

Permalink
Remove loop strength reduction because WasmAddress broke it.
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=243178

Reviewed by Yusuke Suzuki.

When WasmAddress was added, it broke this pass. We should eventually fix it,
but for now we should remove it since it never actually gets applied.

* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/b3/B3Generate.cpp:
(JSC::B3::generateToAir):
* Source/JavaScriptCore/b3/B3ReduceLoopStrength.cpp: Removed.
* Source/JavaScriptCore/b3/B3ReduceLoopStrength.h: Removed.
* Source/JavaScriptCore/b3/testb3.h:
* Source/JavaScriptCore/b3/testb3_1.cpp:
(run):
* Source/JavaScriptCore/b3/testb3_8.cpp:
(testFastForwardCopy32): Deleted.
(testByteCopyLoop): Deleted.
(testByteCopyLoopStartIsLoopDependent): Deleted.
(testByteCopyLoopBoundIsLoopDependent): Deleted.
(addCopyTests): Deleted.

Canonical link: https://commits.webkit.org/256507@main
  • Loading branch information
justinmichaud committed Nov 10, 2022
1 parent abb1790 commit e178496
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 846 deletions.
1 change: 0 additions & 1 deletion Source/JavaScriptCore/Sources.txt
Expand Up @@ -165,7 +165,6 @@ b3/B3PhiChildren.cpp
b3/B3Procedure.cpp
b3/B3PureCSE.cpp
b3/B3ReduceDoubleToFloat.cpp
b3/B3ReduceLoopStrength.cpp
b3/B3ReduceStrength.cpp
b3/B3SSACalculator.cpp
b3/B3SlotBaseValue.cpp
Expand Down
2 changes: 0 additions & 2 deletions Source/JavaScriptCore/b3/B3Generate.cpp
Expand Up @@ -46,7 +46,6 @@
#include "B3OptimizeAssociativeExpressionTrees.h"
#include "B3Procedure.h"
#include "B3ReduceDoubleToFloat.h"
#include "B3ReduceLoopStrength.h"
#include "B3ReduceStrength.h"
#include "B3Validate.h"
#include "CompilerTimingScope.h"
Expand Down Expand Up @@ -92,7 +91,6 @@ void generateToAir(Procedure& procedure)
eliminateCommonSubexpressions(procedure);
eliminateDeadCode(procedure);
inferSwitches(procedure);
reduceLoopStrength(procedure);
if (Options::useB3TailDup())
duplicateTails(procedure);
fixSSA(procedure);
Expand Down

0 comments on commit e178496

Please sign in to comment.