Deploy more smart pointers in Source/WebKit/UIProcess/

https://bugs.webkit.org/show_bug.cgi?id=260847 Reviewed by Chris Dumez. Deployed more smart pointers. * Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::GPUProcessProxy::updatePreferences): * Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp: (WebKit::UIGamepadProvider::gamepadSyncTimerFired): (WebKit::UIGamepadProvider::viewBecameInactive): * Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.cpp: (WebKit::HighPerformanceGraphicsUsageSampler::timerFired): * Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.h: Canonical link: https://commits.webkit.org/267426@main
WebKit · Aug 29, 2023 · e2ae472 · e2ae472
1 parent df817db
commit e2ae472
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp b/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
@@ -721,8 +721,8 @@ void GPUProcessProxy::updatePreferences(WebProcessProxy& webProcess)
     // In practice, all web pages' preferences should agree on these feature flag values.
     GPUProcessPreferences gpuPreferences;
     for (auto page : webProcess.pages()) {
-        auto& webPreferences = page->preferences();
-        if (!webPreferences.useGPUProcessForMediaEnabled())
+        Ref webPreferences = page->preferences();
+        if (!webPreferences->useGPUProcessForMediaEnabled())
             continue;
         gpuPreferences.copyEnabledWebPreferences(webPreferences);
     }

diff --git a/Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp b/Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp
@@ -61,7 +61,7 @@ UIGamepadProvider::~UIGamepadProvider()
 
 void UIGamepadProvider::gamepadSyncTimerFired()
 {
-    auto webPageProxy = platformWebPageProxyForGamepadInput();
+    RefPtr webPageProxy = platformWebPageProxyForGamepadInput();
     if (!webPageProxy || !m_processPoolsUsingGamepads.contains(&webPageProxy->process().processPool()))
         return;
 
@@ -161,7 +161,7 @@ void UIGamepadProvider::viewBecameActive(WebPageProxy& page)
 
 void UIGamepadProvider::viewBecameInactive(WebPageProxy& page)
 {
-    auto pageForGamepadInput = platformWebPageProxyForGamepadInput();
+    RefPtr pageForGamepadInput = platformWebPageProxyForGamepadInput();
     if (pageForGamepadInput == &page)
         platformStopMonitoringInput();
 }

diff --git a/Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.cpp b/Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.cpp
@@ -43,13 +43,16 @@ HighPerformanceGraphicsUsageSampler::HighPerformanceGraphicsUsageSampler(WebProc
     m_timer.startRepeating(samplingInterval);
 }
 
+HighPerformanceGraphicsUsageSampler::~HighPerformanceGraphicsUsageSampler() = default;
+
 void HighPerformanceGraphicsUsageSampler::timerFired()
 {
     bool isUsingHighPerformanceWebGL = false;
     bool isUsingHighPerformanceWebGLInVisibleView = false;
 
     RefPtr<WebPageProxy> firstPage;
-    for (auto& webProcess : m_webProcessPool.processes()) {
+    Ref pool = m_webProcessPool.get();
+    for (auto& webProcess : pool->processes()) {
         for (auto& page : webProcess->pages()) {
             if (!page)
                 continue;

diff --git a/Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.h b/Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.h
@@ -35,11 +35,12 @@ class HighPerformanceGraphicsUsageSampler {
     WTF_MAKE_FAST_ALLOCATED;
 public:
     explicit HighPerformanceGraphicsUsageSampler(WebProcessPool&);
+    ~HighPerformanceGraphicsUsageSampler();
 
 private:
     void timerFired();
 
-    WebProcessPool& m_webProcessPool;
+    CheckedRef<WebProcessPool> m_webProcessPool;
     RunLoop::Timer m_timer;
 };