-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cherry-pick 71b8fba. rdar://123264559
REGRESSION(273742@main): LinkedIn "…" menu does not populate on click https://bugs.webkit.org/show_bug.cgi?id=269848 rdar://123264559 Reviewed by Cameron McCormack. The menu on LinkedIn transitions the `visibility` CSS property. Do a partial revert of 273742@main to revert only the animation wrapper change for the `visibility` property, since it has caused changes that are timing sensitive for the site. Imported WPT that also regressed along with 273742@main to avoid regressing this again. * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation.html: Added. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Canonical link: https://commits.webkit.org/275120@main Identifier: 273664.1309@safari-7619.1.5-branch
- Loading branch information
Showing
4 changed files
with
194 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
122 changes: 122 additions & 0 deletions
122
...ed/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,122 @@ | ||
|
||
PASS CSS Transitions: property <visibility> from [visible] to [visible] at (-1) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [visible] to [visible] at (0) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [visible] to [visible] at (0.5) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [visible] to [visible] at (1) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [visible] to [visible] at (1.5) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [visible] at (-1) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [visible] at (0) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [visible] at (0.5) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [visible] at (1) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [visible] at (1.5) should be [visible] | ||
PASS CSS Animations: property <visibility> from [visible] to [visible] at (-1) should be [visible] | ||
PASS CSS Animations: property <visibility> from [visible] to [visible] at (0) should be [visible] | ||
PASS CSS Animations: property <visibility> from [visible] to [visible] at (0.5) should be [visible] | ||
PASS CSS Animations: property <visibility> from [visible] to [visible] at (1) should be [visible] | ||
PASS CSS Animations: property <visibility> from [visible] to [visible] at (1.5) should be [visible] | ||
PASS Web Animations: property <visibility> from [visible] to [visible] at (-1) should be [visible] | ||
PASS Web Animations: property <visibility> from [visible] to [visible] at (0) should be [visible] | ||
PASS Web Animations: property <visibility> from [visible] to [visible] at (0.5) should be [visible] | ||
PASS Web Animations: property <visibility> from [visible] to [visible] at (1) should be [visible] | ||
PASS Web Animations: property <visibility> from [visible] to [visible] at (1.5) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [visible] to [hidden] at (-1) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [visible] to [hidden] at (0) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [visible] to [hidden] at (0.1) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [visible] to [hidden] at (0.9) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [visible] to [hidden] at (1) should be [hidden] | ||
PASS CSS Transitions: property <visibility> from [visible] to [hidden] at (1.5) should be [hidden] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [hidden] at (-1) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [hidden] at (0) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [hidden] at (0.1) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [hidden] at (0.9) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [hidden] at (1) should be [hidden] | ||
PASS CSS Transitions with transition: all: property <visibility> from [visible] to [hidden] at (1.5) should be [hidden] | ||
PASS CSS Animations: property <visibility> from [visible] to [hidden] at (-1) should be [visible] | ||
PASS CSS Animations: property <visibility> from [visible] to [hidden] at (0) should be [visible] | ||
PASS CSS Animations: property <visibility> from [visible] to [hidden] at (0.1) should be [visible] | ||
PASS CSS Animations: property <visibility> from [visible] to [hidden] at (0.9) should be [visible] | ||
PASS CSS Animations: property <visibility> from [visible] to [hidden] at (1) should be [hidden] | ||
PASS CSS Animations: property <visibility> from [visible] to [hidden] at (1.5) should be [hidden] | ||
PASS Web Animations: property <visibility> from [visible] to [hidden] at (-1) should be [visible] | ||
PASS Web Animations: property <visibility> from [visible] to [hidden] at (0) should be [visible] | ||
PASS Web Animations: property <visibility> from [visible] to [hidden] at (0.1) should be [visible] | ||
PASS Web Animations: property <visibility> from [visible] to [hidden] at (0.9) should be [visible] | ||
PASS Web Animations: property <visibility> from [visible] to [hidden] at (1) should be [hidden] | ||
PASS Web Animations: property <visibility> from [visible] to [hidden] at (1.5) should be [hidden] | ||
PASS CSS Transitions: property <visibility> from [hidden] to [visible] at (-1) should be [hidden] | ||
PASS CSS Transitions: property <visibility> from [hidden] to [visible] at (0) should be [hidden] | ||
PASS CSS Transitions: property <visibility> from [hidden] to [visible] at (0.1) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [hidden] to [visible] at (0.9) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [hidden] to [visible] at (1) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [hidden] to [visible] at (1.5) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [hidden] to [visible] at (-1) should be [hidden] | ||
PASS CSS Transitions with transition: all: property <visibility> from [hidden] to [visible] at (0) should be [hidden] | ||
PASS CSS Transitions with transition: all: property <visibility> from [hidden] to [visible] at (0.1) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [hidden] to [visible] at (0.9) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [hidden] to [visible] at (1) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [hidden] to [visible] at (1.5) should be [visible] | ||
PASS CSS Animations: property <visibility> from [hidden] to [visible] at (-1) should be [hidden] | ||
PASS CSS Animations: property <visibility> from [hidden] to [visible] at (0) should be [hidden] | ||
PASS CSS Animations: property <visibility> from [hidden] to [visible] at (0.1) should be [visible] | ||
PASS CSS Animations: property <visibility> from [hidden] to [visible] at (0.9) should be [visible] | ||
PASS CSS Animations: property <visibility> from [hidden] to [visible] at (1) should be [visible] | ||
PASS CSS Animations: property <visibility> from [hidden] to [visible] at (1.5) should be [visible] | ||
PASS Web Animations: property <visibility> from [hidden] to [visible] at (-1) should be [hidden] | ||
PASS Web Animations: property <visibility> from [hidden] to [visible] at (0) should be [hidden] | ||
PASS Web Animations: property <visibility> from [hidden] to [visible] at (0.1) should be [visible] | ||
PASS Web Animations: property <visibility> from [hidden] to [visible] at (0.9) should be [visible] | ||
PASS Web Animations: property <visibility> from [hidden] to [visible] at (1) should be [visible] | ||
PASS Web Animations: property <visibility> from [hidden] to [visible] at (1.5) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [collapse] to [visible] at (-1) should be [collapse] | ||
PASS CSS Transitions: property <visibility> from [collapse] to [visible] at (0) should be [collapse] | ||
PASS CSS Transitions: property <visibility> from [collapse] to [visible] at (0.1) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [collapse] to [visible] at (0.9) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [collapse] to [visible] at (1) should be [visible] | ||
PASS CSS Transitions: property <visibility> from [collapse] to [visible] at (1.5) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [collapse] to [visible] at (-1) should be [collapse] | ||
PASS CSS Transitions with transition: all: property <visibility> from [collapse] to [visible] at (0) should be [collapse] | ||
PASS CSS Transitions with transition: all: property <visibility> from [collapse] to [visible] at (0.1) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [collapse] to [visible] at (0.9) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [collapse] to [visible] at (1) should be [visible] | ||
PASS CSS Transitions with transition: all: property <visibility> from [collapse] to [visible] at (1.5) should be [visible] | ||
PASS CSS Animations: property <visibility> from [collapse] to [visible] at (-1) should be [collapse] | ||
PASS CSS Animations: property <visibility> from [collapse] to [visible] at (0) should be [collapse] | ||
PASS CSS Animations: property <visibility> from [collapse] to [visible] at (0.1) should be [visible] | ||
PASS CSS Animations: property <visibility> from [collapse] to [visible] at (0.9) should be [visible] | ||
PASS CSS Animations: property <visibility> from [collapse] to [visible] at (1) should be [visible] | ||
PASS CSS Animations: property <visibility> from [collapse] to [visible] at (1.5) should be [visible] | ||
PASS Web Animations: property <visibility> from [collapse] to [visible] at (-1) should be [collapse] | ||
PASS Web Animations: property <visibility> from [collapse] to [visible] at (0) should be [collapse] | ||
PASS Web Animations: property <visibility> from [collapse] to [visible] at (0.1) should be [visible] | ||
PASS Web Animations: property <visibility> from [collapse] to [visible] at (0.9) should be [visible] | ||
PASS Web Animations: property <visibility> from [collapse] to [visible] at (1) should be [visible] | ||
PASS Web Animations: property <visibility> from [collapse] to [visible] at (1.5) should be [visible] | ||
FAIL CSS Transitions: property <visibility> from [collapse] to [hidden] at (-0.3) should be [hidden] assert_equals: expected "hidden " but got "collapse " | ||
FAIL CSS Transitions: property <visibility> from [collapse] to [hidden] at (0) should be [hidden] assert_equals: expected "hidden " but got "collapse " | ||
FAIL CSS Transitions: property <visibility> from [collapse] to [hidden] at (0.3) should be [hidden] assert_equals: expected "hidden " but got "collapse " | ||
PASS CSS Transitions: property <visibility> from [collapse] to [hidden] at (0.5) should be [hidden] | ||
PASS CSS Transitions: property <visibility> from [collapse] to [hidden] at (0.6) should be [hidden] | ||
PASS CSS Transitions: property <visibility> from [collapse] to [hidden] at (1) should be [hidden] | ||
PASS CSS Transitions: property <visibility> from [collapse] to [hidden] at (1.5) should be [hidden] | ||
FAIL CSS Transitions with transition: all: property <visibility> from [collapse] to [hidden] at (-0.3) should be [hidden] assert_equals: expected "hidden " but got "collapse " | ||
FAIL CSS Transitions with transition: all: property <visibility> from [collapse] to [hidden] at (0) should be [hidden] assert_equals: expected "hidden " but got "collapse " | ||
FAIL CSS Transitions with transition: all: property <visibility> from [collapse] to [hidden] at (0.3) should be [hidden] assert_equals: expected "hidden " but got "collapse " | ||
PASS CSS Transitions with transition: all: property <visibility> from [collapse] to [hidden] at (0.5) should be [hidden] | ||
PASS CSS Transitions with transition: all: property <visibility> from [collapse] to [hidden] at (0.6) should be [hidden] | ||
PASS CSS Transitions with transition: all: property <visibility> from [collapse] to [hidden] at (1) should be [hidden] | ||
PASS CSS Transitions with transition: all: property <visibility> from [collapse] to [hidden] at (1.5) should be [hidden] | ||
PASS CSS Animations: property <visibility> from [collapse] to [hidden] at (-0.3) should be [collapse] | ||
PASS CSS Animations: property <visibility> from [collapse] to [hidden] at (0) should be [collapse] | ||
PASS CSS Animations: property <visibility> from [collapse] to [hidden] at (0.3) should be [collapse] | ||
PASS CSS Animations: property <visibility> from [collapse] to [hidden] at (0.5) should be [hidden] | ||
PASS CSS Animations: property <visibility> from [collapse] to [hidden] at (0.6) should be [hidden] | ||
PASS CSS Animations: property <visibility> from [collapse] to [hidden] at (1) should be [hidden] | ||
PASS CSS Animations: property <visibility> from [collapse] to [hidden] at (1.5) should be [hidden] | ||
PASS Web Animations: property <visibility> from [collapse] to [hidden] at (-0.3) should be [collapse] | ||
PASS Web Animations: property <visibility> from [collapse] to [hidden] at (0) should be [collapse] | ||
PASS Web Animations: property <visibility> from [collapse] to [hidden] at (0.3) should be [collapse] | ||
PASS Web Animations: property <visibility> from [collapse] to [hidden] at (0.5) should be [hidden] | ||
PASS Web Animations: property <visibility> from [collapse] to [hidden] at (0.6) should be [hidden] | ||
PASS Web Animations: property <visibility> from [collapse] to [hidden] at (1) should be [hidden] | ||
PASS Web Animations: property <visibility> from [collapse] to [hidden] at (1.5) should be [hidden] | ||
|
70 changes: 70 additions & 0 deletions
70
...s/imported/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
<!DOCTYPE html> | ||
<meta charset="UTF-8"> | ||
<title>visibility interpolation</title> | ||
<link rel="help" href="https://www.w3.org/TR/CSS2/visufx.html#visibility"> | ||
<meta name="assert" content="visibility supports"> | ||
|
||
<script src="/resources/testharness.js"></script> | ||
<script src="/resources/testharnessreport.js"></script> | ||
<script src="/css/support/interpolation-testcommon.js"></script> | ||
|
||
<body> | ||
<script> | ||
test_interpolation({ | ||
property: 'visibility', | ||
from: 'visible', | ||
to: 'visible' | ||
}, [ | ||
{at: -1, expect: 'visible'}, | ||
{at: 0, expect: 'visible'}, | ||
{at: 0.5, expect: 'visible'}, | ||
{at: 1, expect: 'visible'}, | ||
{at: 1.5, expect: 'visible'}, | ||
]); | ||
|
||
test_interpolation({ | ||
property: 'visibility', | ||
from: 'visible', | ||
to: 'hidden' | ||
}, [ | ||
{at: -1, expect: 'visible'}, | ||
{at: 0, expect: 'visible'}, | ||
{at: 0.1, expect: 'visible'}, | ||
{at: 0.9, expect: 'visible'}, | ||
{at: 1, expect: 'hidden'}, | ||
{at: 1.5, expect: 'hidden'}, | ||
]); | ||
|
||
test_interpolation({ | ||
property: 'visibility', | ||
from: 'hidden', | ||
to: 'visible' | ||
}, [ | ||
{at: -1, expect: 'hidden'}, | ||
{at: 0, expect: 'hidden'}, | ||
{at: 0.1, expect: 'visible'}, | ||
{at: 0.9, expect: 'visible'}, | ||
{at: 1, expect: 'visible'}, | ||
{at: 1.5, expect: 'visible'}, | ||
]); | ||
|
||
test_interpolation({ | ||
property: 'visibility', | ||
from: 'collapse', | ||
to: 'visible' | ||
}, [ | ||
{at: -1, expect: 'collapse'}, | ||
{at: 0, expect: 'collapse'}, | ||
{at: 0.1, expect: 'visible'}, | ||
{at: 0.9, expect: 'visible'}, | ||
{at: 1, expect: 'visible'}, | ||
{at: 1.5, expect: 'visible'}, | ||
]); | ||
|
||
test_no_interpolation({ | ||
property: 'visibility', | ||
from: 'collapse', | ||
to: 'hidden' | ||
}); | ||
</script> | ||
</body> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters