Skip to content

Commit

Permalink
Incorrect documentation for webkit-cookie-manager-get-cookies-finish
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=263967

Reviewed by Carlos Garcia Campos.

This fixes a serious typo. GSList and GList are entirely separate,
incompatible types. This tricked the Eclipse developers and now they
have a type confusion problem because they trusted our incorrect
documentation. See also: eclipse-platform/eclipse.platform.swt#842

* Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp:

Canonical link: https://commits.webkit.org/270058@main
  • Loading branch information
mcatanzaro committed Nov 1, 2023
1 parent 8a9f21d commit e57b85e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ void webkit_cookie_manager_get_cookies(WebKitCookieManager* manager, const gchar
*
* Finish an asynchronous operation started with webkit_cookie_manager_get_cookies().
*
* The return value is a #GSList of #SoupCookie instances which should be released
* The return value is a #GList of #SoupCookie instances which should be released
* with g_list_free_full() and soup_cookie_free().
*
* Returns: (element-type SoupCookie) (transfer full): A #GList of #SoupCookie instances.
Expand Down Expand Up @@ -606,7 +606,7 @@ void webkit_cookie_manager_get_all_cookies(WebKitCookieManager* manager, GCancel
*
* Finish an asynchronous operation started with webkit_cookie_manager_get_all_cookies().
*
* The return value is a #GSList of #SoupCookie instances which should be released
* The return value is a #GList of #SoupCookie instances which should be released
* with g_list_free_full() and soup_cookie_free().
*
* Returns: (element-type SoupCookie) (transfer full): A #GList of #SoupCookie instances.
Expand Down

0 comments on commit e57b85e

Please sign in to comment.