Skip to content

Commit

Permalink
Merge r177518 - Web Inspector: ASSERT seen closing/opening multiple i…
Browse files Browse the repository at this point in the history
…nspectors

https://bugs.webkit.org/show_bug.cgi?id=139783

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-18
Reviewed by Timothy Hatcher.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::nodeForObjectId):

Canonical link: https://commits.webkit.org/154760.288@webkitgtk/2.6
git-svn-id: https://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.6@178358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JosephPecoraro authored and carlosgcampos committed Jan 13, 2015
1 parent f99ada8 commit e765ab0
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
10 changes: 10 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,13 @@
2014-12-18 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: ASSERT seen closing/opening multiple inspectors
https://bugs.webkit.org/show_bug.cgi?id=139783

Reviewed by Timothy Hatcher.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::nodeForObjectId):

2014-12-16 Chris Dumez <cdumez@apple.com>

REGRESSION (r163928): Animated GIFs are not resumed when translated into view using -webkit-transform
Expand Down
3 changes: 3 additions & 0 deletions Source/WebCore/inspector/InspectorDOMAgent.cpp
Expand Up @@ -1954,6 +1954,9 @@ Node* InspectorDOMAgent::nodeForPath(const String& path)
Node* InspectorDOMAgent::nodeForObjectId(const String& objectId)
{
InjectedScript injectedScript = m_injectedScriptManager->injectedScriptForObjectId(objectId);
if (injectedScript.hasNoValue())
return nullptr;

Deprecated::ScriptValue value = injectedScript.findObjectById(objectId);
return InspectorDOMAgent::scriptValueAsNode(value);
}
Expand Down

0 comments on commit e765ab0

Please sign in to comment.