Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update isValueOutOfRangeForProperty() to account for more CSS properties
https://bugs.webkit.org/show_bug.cgi?id=249050 Reviewed by Sam Weinig. Update isValueOutOfRangeForProperty() to account for more CSS properties that have range limits: - border-image-width: length or percentage or number >= 0 https://w3c.github.io/csswg-drafts/css-backgrounds/#border-image-width - border-top-width, border-right-width, border-bottom-width, border-left-width: length >= 0 https://w3c.github.io/csswg-drafts/css-backgrounds/#the-border-width - row-gap, column-gap: length or percentage >= 0 https://w3c.github.io/csswg-drafts/css-align/#column-row-gap - column-width: length >= 0 https://w3c.github.io/csswg-drafts/css-multicol-1/#propdef-column-width - flex-basis: length or percentage >= 0 https://w3c.github.io/csswg-drafts/css-flexbox/#flex-basis-property - grid-auto-columns, grid-auto-rows: length or percentage >= 0 https://w3c.github.io/csswg-drafts/css-grid/#auto-tracks - line-height: length, number or percentage >= 0 https://w3c.github.io/csswg-drafts/css-inline/#line-height-property - max-height: length or percentage >= 0 https://w3c.github.io/csswg-drafts/css2/#propdef-max-height - max-width: length or percentage >= 0 https://w3c.github.io/csswg-drafts/css2/#propdef-max-width - outline-width: length >= 0 https://w3c.github.io/csswg-drafts/css-ui/#outline-width - scroll-padding-inline-start, scroll-padding-block-start, scroll-padding-inline-end, scroll-padding-block-end: length or percentage >= 0 https://w3c.github.io/csswg-drafts/css-scroll-snap/#padding-longhands-logical - stroke-miterlimit: number >= 0 https://svgwg.org/svg2-draft/painting.html#StrokeMiterlimitProperty - font-weight: number in range [1, 1000] https://w3c.github.io/csswg-drafts/css-fonts/#font-weight-prop All these properties are covered by the WPT tests but the tests still fail because of: - #7387 (a lot more tests start passing with this PR) For now, I have extracted these test cases into their own layout test. * LayoutTests/fast/css/css-typed-om/style-property-map-set-negative-value-expected.txt: * LayoutTests/fast/css/css-typed-om/style-property-map-set-negative-value.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-duration-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-iteration-count-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/border-width-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-width-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/flex-basis-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-weight-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/gap-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/height-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/line-height-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/logical-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-width-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/scroll-padding-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/stroke-miterlimit-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/width-expected.txt: * Source/WebCore/css/typedom/CSSUnitValue.cpp: (WebCore::isValueOutOfRangeForProperty): Canonical link: https://commits.webkit.org/257757@main
- Loading branch information
Showing
18 changed files
with
295 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...rm-tests/css/css-typed-om/the-stylepropertymap/properties/animation-duration-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.