Skip to content

Commit

Permalink
Regression(266612@main) Bad jsCast() when opening Safari Web extensio…
Browse files Browse the repository at this point in the history
…ns settings panel

https://bugs.webkit.org/show_bug.cgi?id=259939
rdar://113579295

Unreviewed, partial revert of 266612@main to address the assertion hit.

* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::fillTransferMap):

Canonical link: https://commits.webkit.org/266697@main
  • Loading branch information
cdumez committed Aug 8, 2023
1 parent 322a31d commit e8ed2fc
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Source/WebCore/bindings/js/SerializedScriptValue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -917,6 +917,9 @@ class CloneSerializer : CloneBase {
template<typename T>
void fillTransferMap(const Vector<T>& input, ObjectPool& result)
{
if (input.isEmpty())
return;

auto* globalObject = jsCast<JSDOMGlobalObject*>(m_lexicalGlobalObject);
for (size_t i = 0; i < input.size(); ++i) {
if (auto* object = toJS(globalObject, globalObject, input[i].get()).getObject())
Expand Down

0 comments on commit e8ed2fc

Please sign in to comment.