Skip to content

Commit

Permalink
Source/WebCore:
Browse files Browse the repository at this point in the history
Delete code for keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto and Darin Adler.

Deleted most of code for keygen since it has been always disabled for a while but preserve
the HTML tree builder behavior for compatibility purposes as required by the HTML5 specification.

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Headers.cmake:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h: Also remove the entry for HTMLSlotElement which is no longer
used since the runtime flag for enabling shadow DOM had been removed.
* css/html.css:
* css/legacyFormControlsIOS.css:
* css/themeWin.css:
* editing/MarkupAccumulator.cpp:
(WebCore::elementCannotHaveEndTag):
* html/HTMLKeygenElement.cpp: Removed.
* html/HTMLKeygenElement.h: Removed.
* html/HTMLKeygenElement.idl: Removed.
* html/HTMLTagNames.in:
* html/shadow/ShadowPseudoIds.cpp:
(WebCore::ShadowPseudoIds::webkitKeygenSelect): Deleted.
* html/shadow/ShadowPseudoIds.h:
* mathml/MathMLPresentationElement.cpp:
(WebCore::MathMLPresentationElement::isPhrasingContent):
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setKeygenElementEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::keygenElementEnabled const): Deleted.

Source/WebKit:
Delete code for keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto and Darin Adler.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetRequestVideoFrameCallbackEnabled):
(WKPreferencesGetRequestVideoFrameCallbackEnabled):
(WKPreferencesSetKeygenElementEnabled):
(WKPreferencesGetKeygenElementEnabled):
(WKPreferencesGetXSSAuditorEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/Automation/atoms/ElementAttribute.js:
(isBooleanAttribute):
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLPrivate.cpp:

Source/WebKitLegacy/mac:
Delete runtime preference for enabling keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto.

* WebView/WebPreferences.mm:
(-[WebPreferences keygenElementEnabled]):
(-[WebPreferences setKeygenElementEnabled:]):
* WebView/WebPreferencesPrivate.h:

Source/WebKitLegacy/win:
Delete runtime preference for enabling keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto.

* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::keygenElementEnabled):
(WebPreferences::setKeygenElementEnabled):
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WTF:
Delete code for keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto.

* Scripts/Preferences/WebPreferencesInternal.yaml:

LayoutTests:
Delete code for keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto.

Deleted the relevant keygen tests and rebaselined other tests.

Most of the tests that happens to test keygen elements along side other form control elements
have been updated to expect keygen to behave like HTMLUnknownElement as expected.

* accessibility/content-changed-notification-causes-crash.html:
* accessibility/contenteditable-table-check-causes-crash.html:
* accessibility/duplicate-axrenderobject-crash-expected.txt:
* accessibility/duplicate-axrenderobject-crash.html:
* fast/block/float/float-not-removed-from-first-letter-expected.txt:
* fast/block/float/float-not-removed-from-first-letter.html:
* fast/block/float/split-inline-sibling-of-float-crash.html:
* fast/css/pseudo-required-optional-unapplied.html:
* fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html:
* fast/dom/HTMLKeygenElement/keygen-expected.txt: Removed.
* fast/dom/HTMLKeygenElement/keygen-keytype-expected.txt: Removed.
* fast/dom/HTMLKeygenElement/keygen-keytype.html: Removed.
* fast/dom/HTMLKeygenElement/keygen.html: Removed.
* fast/dom/adopt-node-crash-2-expected.txt:
* fast/dom/adopt-node-crash-2.html:
* fast/dom/attribute-set-before-element-in-tree.html:
* fast/dom/domstring-attribute-reflection-expected.txt:
* fast/dom/domstring-attribute-reflection.html:
* fast/dom/set-custom-validity-with-too-few-arguments-expected.txt:
* fast/dom/set-custom-validity-with-too-few-arguments.html:
* fast/dom/tabindex-defaults-expected.txt:
* fast/dom/tabindex-defaults.html:
* fast/dom/wrapper-classes-expected.txt:
* fast/dom/wrapper-classes.html:
* fast/dynamic/insertAdjacentHTML-allowed-parents.html:
* fast/flexbox/crash-button-keygen.html:
* fast/forms/ValidityState-001-expected.txt:
* fast/forms/ValidityState-001.html:
* fast/forms/autofocus-keygen-expected.txt: Removed.
* fast/forms/autofocus-keygen.html: Removed.
* fast/forms/checkValidity-001-expected.txt:
* fast/forms/checkValidity-001.html:
* fast/forms/fieldset/fieldset-elements-expected.txt:
* fast/forms/fieldset/fieldset-elements-htmlcollection-expected.txt:
* fast/forms/fieldset/fieldset-elements-htmlcollection.html:
* fast/forms/fieldset/fieldset-elements.html:
* fast/forms/form-associated-element-crash3.html:
* fast/forms/form-attribute-expected.txt:
* fast/forms/form-attribute.html:
* fast/forms/form-collection-elements-expected.txt:
* fast/forms/form-collection-elements-order-expected.txt:
* fast/forms/form-collection-elements-order.html:
* fast/forms/form-collection-elements.html:
* fast/forms/form-collection-radio-node-list-expected.txt:
* fast/forms/form-collection-radio-node-list.html:
* fast/forms/label/labelable-elements-expected.txt:
* fast/forms/label/labelable-elements.html:
* fast/forms/label/labels-add-htmlFor-label-expected.txt:
* fast/forms/label/labels-add-htmlFor-label.html:
* fast/forms/label/labels-add-parent-label-expected.txt:
* fast/forms/label/labels-add-parent-label.html:
* fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-change-htmlFor-attribute.html:
* fast/forms/label/labels-multiple-sibling-labels-expected.txt:
* fast/forms/label/labels-multiple-sibling-labels.html:
* fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
* fast/forms/label/labels-parent-and-sibling-labels.html:
* fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-remove-htmlFor-attribute.html:
* fast/forms/label/labels-remove-htmlFor-label-expected.txt:
* fast/forms/label/labels-remove-htmlFor-label.html:
* fast/forms/label/labels-remove-parent-label-expected.txt:
* fast/forms/label/labels-remove-parent-label.html:
* fast/forms/large-parts.html:
* fast/forms/resources/common.js:
(createFormControlDataSet): Removed keygen form the list of form control elements.
* fast/forms/scrollheight-with-mutation-crash.html:
* fast/forms/setCustomValidity-arguments-expected.txt:
* fast/forms/setCustomValidity-arguments.html:
* fast/forms/setCustomValidity-existence-expected.txt:
* fast/forms/setCustomValidity-existence.html:
* fast/forms/setCustomValidity-null-parameter-expected.txt:
* fast/forms/setCustomValidity-null-parameter.html:
* fast/forms/state-restore-skip-stateless.html:
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure.html:
* fast/forms/validationMessage-expected.txt:
* fast/forms/validationMessage.html:
* fast/forms/willvalidate-expected.txt:
* fast/forms/willvalidate.html:
* fast/html/clone-keygen-expected.txt: Removed.
* fast/html/clone-keygen.html: Removed.
* fast/html/keygen.html: Removed.
* fast/html/marquee-reparent-check.html:
* fast/invalid/residual-style-expected.html:
* fast/invalid/residual-style.html:
* fast/multicol/span/positioned-child-not-removed-crash-expected.txt:
* fast/multicol/span/positioned-child-not-removed-crash.html:
* fast/ruby/float-object-doesnt-crash.html:
* fast/shadow-dom/keygen-shadow-manipulation-expected.txt:
* fast/shadow-dom/keygen-shadow-manipulation.html:
* fast/table/crash-splitColumn-2.html:
* fast/table/multiple-captions-crash3-expected.html:
* fast/table/multiple-captions-crash3.html:
* http/tests/misc/resources/check-keygen-post.py: Removed.
* http/tests/misc/submit-post-keygen-expected.txt: Removed.
* http/tests/misc/submit-post-keygen.html: Removed.
* imported/blink/fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html: Removed.
* imported/blink/fast/dom/shadow/shadowdom-for-keygen-only-shadow.html: Removed.
* imported/blink/fast/text/international-iteration-simple-text.html:
* platform/glib/fast/html/keygen-expected.txt: Removed.
* platform/gtk/fast/forms/label/labelable-elements-expected.txt:
* platform/gtk/fast/html/keygen-expected.png: Removed.
* platform/ios-wk2/TestExpectations:
* platform/ios-wk2/fast/forms/label/labelable-elements-expected.txt:
* platform/ios/fast/html/keygen-expected.txt: Removed.
* platform/mac-wk2/fast/forms/label/labelable-elements-expected.txt:
* platform/mac/fast/html/keygen-expected.png: Removed.
* platform/mac/fast/html/keygen-expected.txt: Removed.
* platform/win/TestExpectations:
* platform/wincairo/fast/html/keygen-expected.txt: Removed.
* svg/dom/css-animate-input-foucs-crash-expected.txt:
* svg/dom/css-animate-input-foucs-crash.html:



Canonical link: https://commits.webkit.org/246580@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
rniwa committed Jan 31, 2022
1 parent d085008 commit eb67381
Show file tree
Hide file tree
Showing 146 changed files with 400 additions and 942 deletions.
125 changes: 125 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,128 @@
2022-01-30 Ryosuke Niwa <rniwa@webkit.org>

Delete code for keygen element
https://bugs.webkit.org/show_bug.cgi?id=235867

Reviewed by Antti Koivisto.

Deleted the relevant keygen tests and rebaselined other tests.

Most of the tests that happens to test keygen elements along side other form control elements
have been updated to expect keygen to behave like HTMLUnknownElement as expected.

* accessibility/content-changed-notification-causes-crash.html:
* accessibility/contenteditable-table-check-causes-crash.html:
* accessibility/duplicate-axrenderobject-crash-expected.txt:
* accessibility/duplicate-axrenderobject-crash.html:
* fast/block/float/float-not-removed-from-first-letter-expected.txt:
* fast/block/float/float-not-removed-from-first-letter.html:
* fast/block/float/split-inline-sibling-of-float-crash.html:
* fast/css/pseudo-required-optional-unapplied.html:
* fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html:
* fast/dom/HTMLKeygenElement/keygen-expected.txt: Removed.
* fast/dom/HTMLKeygenElement/keygen-keytype-expected.txt: Removed.
* fast/dom/HTMLKeygenElement/keygen-keytype.html: Removed.
* fast/dom/HTMLKeygenElement/keygen.html: Removed.
* fast/dom/adopt-node-crash-2-expected.txt:
* fast/dom/adopt-node-crash-2.html:
* fast/dom/attribute-set-before-element-in-tree.html:
* fast/dom/domstring-attribute-reflection-expected.txt:
* fast/dom/domstring-attribute-reflection.html:
* fast/dom/set-custom-validity-with-too-few-arguments-expected.txt:
* fast/dom/set-custom-validity-with-too-few-arguments.html:
* fast/dom/tabindex-defaults-expected.txt:
* fast/dom/tabindex-defaults.html:
* fast/dom/wrapper-classes-expected.txt:
* fast/dom/wrapper-classes.html:
* fast/dynamic/insertAdjacentHTML-allowed-parents.html:
* fast/flexbox/crash-button-keygen.html:
* fast/forms/ValidityState-001-expected.txt:
* fast/forms/ValidityState-001.html:
* fast/forms/autofocus-keygen-expected.txt: Removed.
* fast/forms/autofocus-keygen.html: Removed.
* fast/forms/checkValidity-001-expected.txt:
* fast/forms/checkValidity-001.html:
* fast/forms/fieldset/fieldset-elements-expected.txt:
* fast/forms/fieldset/fieldset-elements-htmlcollection-expected.txt:
* fast/forms/fieldset/fieldset-elements-htmlcollection.html:
* fast/forms/fieldset/fieldset-elements.html:
* fast/forms/form-associated-element-crash3.html:
* fast/forms/form-attribute-expected.txt:
* fast/forms/form-attribute.html:
* fast/forms/form-collection-elements-expected.txt:
* fast/forms/form-collection-elements-order-expected.txt:
* fast/forms/form-collection-elements-order.html:
* fast/forms/form-collection-elements.html:
* fast/forms/form-collection-radio-node-list-expected.txt:
* fast/forms/form-collection-radio-node-list.html:
* fast/forms/label/labelable-elements-expected.txt:
* fast/forms/label/labelable-elements.html:
* fast/forms/label/labels-add-htmlFor-label-expected.txt:
* fast/forms/label/labels-add-htmlFor-label.html:
* fast/forms/label/labels-add-parent-label-expected.txt:
* fast/forms/label/labels-add-parent-label.html:
* fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-change-htmlFor-attribute.html:
* fast/forms/label/labels-multiple-sibling-labels-expected.txt:
* fast/forms/label/labels-multiple-sibling-labels.html:
* fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
* fast/forms/label/labels-parent-and-sibling-labels.html:
* fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-remove-htmlFor-attribute.html:
* fast/forms/label/labels-remove-htmlFor-label-expected.txt:
* fast/forms/label/labels-remove-htmlFor-label.html:
* fast/forms/label/labels-remove-parent-label-expected.txt:
* fast/forms/label/labels-remove-parent-label.html:
* fast/forms/large-parts.html:
* fast/forms/resources/common.js:
(createFormControlDataSet): Removed keygen form the list of form control elements.
* fast/forms/scrollheight-with-mutation-crash.html:
* fast/forms/setCustomValidity-arguments-expected.txt:
* fast/forms/setCustomValidity-arguments.html:
* fast/forms/setCustomValidity-existence-expected.txt:
* fast/forms/setCustomValidity-existence.html:
* fast/forms/setCustomValidity-null-parameter-expected.txt:
* fast/forms/setCustomValidity-null-parameter.html:
* fast/forms/state-restore-skip-stateless.html:
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure.html:
* fast/forms/validationMessage-expected.txt:
* fast/forms/validationMessage.html:
* fast/forms/willvalidate-expected.txt:
* fast/forms/willvalidate.html:
* fast/html/clone-keygen-expected.txt: Removed.
* fast/html/clone-keygen.html: Removed.
* fast/html/keygen.html: Removed.
* fast/html/marquee-reparent-check.html:
* fast/invalid/residual-style-expected.html:
* fast/invalid/residual-style.html:
* fast/multicol/span/positioned-child-not-removed-crash-expected.txt:
* fast/multicol/span/positioned-child-not-removed-crash.html:
* fast/ruby/float-object-doesnt-crash.html:
* fast/shadow-dom/keygen-shadow-manipulation-expected.txt:
* fast/shadow-dom/keygen-shadow-manipulation.html:
* fast/table/crash-splitColumn-2.html:
* fast/table/multiple-captions-crash3-expected.html:
* fast/table/multiple-captions-crash3.html:
* http/tests/misc/resources/check-keygen-post.py: Removed.
* http/tests/misc/submit-post-keygen-expected.txt: Removed.
* http/tests/misc/submit-post-keygen.html: Removed.
* imported/blink/fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html: Removed.
* imported/blink/fast/dom/shadow/shadowdom-for-keygen-only-shadow.html: Removed.
* imported/blink/fast/text/international-iteration-simple-text.html:
* platform/glib/fast/html/keygen-expected.txt: Removed.
* platform/gtk/fast/forms/label/labelable-elements-expected.txt:
* platform/gtk/fast/html/keygen-expected.png: Removed.
* platform/ios-wk2/TestExpectations:
* platform/ios-wk2/fast/forms/label/labelable-elements-expected.txt:
* platform/ios/fast/html/keygen-expected.txt: Removed.
* platform/mac-wk2/fast/forms/label/labelable-elements-expected.txt:
* platform/mac/fast/html/keygen-expected.png: Removed.
* platform/mac/fast/html/keygen-expected.txt: Removed.
* platform/win/TestExpectations:
* platform/wincairo/fast/html/keygen-expected.txt: Removed.
* svg/dom/css-animate-input-foucs-crash-expected.txt:
* svg/dom/css-animate-input-foucs-crash.html:

2022-01-30 Ryosuke Niwa <rniwa@webkit.org>

Delete runtime preference for enabling input events
Expand Down
@@ -1,4 +1,4 @@
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> <!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
<script src="../resources/js-test-pre.js"></script>
Expand Down
@@ -1,4 +1,4 @@
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"><!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
<script src="../resources/js-test-pre.js"></script>
Expand Down
@@ -1,7 +1,6 @@
PASS successfullyParsed is true

TEST COMPLETE

Ensures that it's not possible to have two AXRenderObjects that point to the same renderer, if the initialization of an AXRenderObject results in another object with the same renderer being created before AXObjectCache has added that mapping to its hash.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
@@ -1,4 +1,4 @@
<!doctype html><!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<!doctype html>
<html>
<head>
<script src="../resources/js-test-pre.js"></script>
Expand Down
@@ -1,3 +1,2 @@
Webkit Bug 86019 - Crash due to floats not removed from first-letter element.

PASS. WebKit didn't crash.
@@ -1,4 +1,4 @@
<!DOCTYPE html><!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<!DOCTYPE html>
<html>
Webkit Bug 86019 - Crash due to floats not removed from first-letter element.
<style>
Expand Down
@@ -1,4 +1,4 @@
<html><!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<html>
<p style='white: fuchsia; padding: 198px 108 2147483647px; '></p>
<myelement>
<body>
Expand Down
@@ -1,4 +1,4 @@
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"><!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
<script src="../../resources/js-test-pre.js"></script>
Expand Down
@@ -1,4 +1,4 @@
<head><!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<head>
<script>
function pass() {
var div = document.createElement('div');
Expand Down
10 changes: 0 additions & 10 deletions LayoutTests/fast/dom/HTMLKeygenElement/keygen-expected.txt

This file was deleted.

20 changes: 0 additions & 20 deletions LayoutTests/fast/dom/HTMLKeygenElement/keygen-keytype-expected.txt

This file was deleted.

29 changes: 0 additions & 29 deletions LayoutTests/fast/dom/HTMLKeygenElement/keygen-keytype.html

This file was deleted.

24 changes: 0 additions & 24 deletions LayoutTests/fast/dom/HTMLKeygenElement/keygen.html

This file was deleted.

5 changes: 2 additions & 3 deletions LayoutTests/fast/dom/adopt-node-crash-2-expected.txt
@@ -1,4 +1,3 @@
Tests for a crash due to adopting a DOM node when unfocusing. Test passes if it doesn't crash.

PASS: Focused node should be keygen
PASS: Focused node should no longer be keygen
PASS: Focused node should not be keygen
PASS: Focused node should not be keygen
6 changes: 3 additions & 3 deletions LayoutTests/fast/dom/adopt-node-crash-2.html
@@ -1,4 +1,4 @@
<!DOCTYPE html><!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<!DOCTYPE html>
<html>
<div>Tests for a crash due to adopting a DOM node when unfocusing. Test passes if it doesn't crash.</div>
<script>
Expand Down Expand Up @@ -29,9 +29,9 @@
}

function doit() {
assert_true(document.activeElement == keygen, "Focused node should be keygen");
assert_true(document.activeElement != keygen, "Focused node should not be keygen");
div1.outerHTML = header1.outerHTML;
assert_true(document.activeElement != keygen, "Focused node should no longer be keygen");
assert_true(document.activeElement != keygen, "Focused node should not be keygen");
document.implementation.createDocument("", "", null).adoptNode(div2);
if (window.internals)
internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks();
Expand Down
@@ -1,4 +1,4 @@
<!DOCTYPE html><!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<!DOCTYPE html>
<html>
<head>
<script src="../../resources/js-test-pre.js"></script>
Expand Down
30 changes: 0 additions & 30 deletions LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt
Expand Up @@ -148,36 +148,6 @@ PASS element.setAttribute("step", 456); element.step is "456"
PASS element.getAttribute("step") is "456"


Reflected DOMString attribute test for keygen/@name
Initial value:
PASS element.name is ""
PASS element.getAttribute("name") is null
Setting a value via the IDL attribute:
PASS element.name = "foo"; element.name is "foo"
PASS element.getAttribute("name") is "foo"
Setting a value via the content attribute:
PASS element.setAttribute("name", " bar\n"); element.name is " bar\n"
PASS element.getAttribute("name") is " bar\n"
Setting null via the IDL attribute:
PASS element.name = null; element.name is "null"
PASS element.getAttribute("name") is "null"
Setting null via the content attribute:
PASS element.setAttribute("name", null); element.name is "null"
PASS element.getAttribute("name") is "null"
Setting undefined via the IDL attribute:
PASS element.name = undefined; element.name is "undefined"
PASS element.getAttribute("name") is "undefined"
Setting undefined via the content attribute:
PASS element.setAttribute("name", undefined); element.name is "undefined"
PASS element.getAttribute("name") is "undefined"
Setting non-string via the IDL attribute:
PASS element.name = 123; element.name is "123"
PASS element.getAttribute("name") is "123"
Setting non-string via the content attribute:
PASS element.setAttribute("name", 456); element.name is "456"
PASS element.getAttribute("name") is "456"


Reflected DOMString attribute test for object/@name
Initial value:
PASS element.name is ""
Expand Down
3 changes: 1 addition & 2 deletions LayoutTests/fast/dom/domstring-attribute-reflection.html
@@ -1,4 +1,4 @@
<!DOCTYPE html><!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<!DOCTYPE html>
<html>
<body>
<script src="../../resources/js-test-pre.js"></script>
Expand Down Expand Up @@ -53,7 +53,6 @@
testDOMStringReflection('form', 'name');
testDOMStringReflection('input', 'name');
testDOMStringReflection('input', 'step');
testDOMStringReflection('keygen', 'name');
testDOMStringReflection('object', 'name');
testDOMStringReflection('output', 'name');
testDOMStringReflection('select', 'name');
Expand Down
Expand Up @@ -6,7 +6,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS b.setCustomValidity() threw exception TypeError: Not enough arguments.
PASS fs.setCustomValidity() threw exception TypeError: Not enough arguments.
PASS i.setCustomValidity() threw exception TypeError: Not enough arguments.
PASS k.setCustomValidity() threw exception TypeError: Not enough arguments.
PASS k.setCustomValidity() threw exception TypeError: k.setCustomValidity is not a function. (In 'k.setCustomValidity()', 'k.setCustomValidity' is undefined).
PASS successfullyParsed is true

TEST COMPLETE
Expand Down
@@ -1,4 +1,4 @@
<!DOCTYPE HTML><!-- webkit-test-runner [ KeygenElementEnabled=true ] -->
<!DOCTYPE HTML>
<html>
<head>
<script src="../../resources/js-test-pre.js"></script>
Expand Down
6 changes: 3 additions & 3 deletions LayoutTests/fast/dom/tabindex-defaults-expected.txt
Expand Up @@ -11,7 +11,7 @@ PASS button.tabIndex is 0
PASS input.tabIndex is 0
PASS select.tabIndex is 0
PASS textarea.tabIndex is 0
PASS keygen.tabIndex is 0
PASS keygen.tabIndex is -1
PASS activeSummary.tabIndex is 0
PASS editableDiv.tabIndex is -1
PASS normalDiv.tabIndex is -1
Expand All @@ -31,7 +31,7 @@ PASS button.setAttribute("tabindex", "invalid"); button.tabIndex is 0
PASS input.setAttribute("tabindex", "invalid"); input.tabIndex is 0
PASS select.setAttribute("tabindex", "invalid"); select.tabIndex is 0
PASS textarea.setAttribute("tabindex", "invalid"); textarea.tabIndex is 0
PASS keygen.setAttribute("tabindex", "invalid"); keygen.tabIndex is 0
PASS keygen.setAttribute("tabindex", "invalid"); keygen.tabIndex is -1
PASS activeSummary.setAttribute("tabindex", "invalid"); activeSummary.tabIndex is 0
PASS editableDiv.setAttribute("tabindex", "invalid"); editableDiv.tabIndex is -1
PASS normalDiv.setAttribute("tabindex", "invalid"); normalDiv.tabIndex is -1
Expand All @@ -51,7 +51,7 @@ PASS button.setAttribute("tabindex", "9999999999"); button.tabIndex is 0
PASS input.setAttribute("tabindex", "9999999999"); input.tabIndex is 0
PASS select.setAttribute("tabindex", "9999999999"); select.tabIndex is 0
PASS textarea.setAttribute("tabindex", "9999999999"); textarea.tabIndex is 0
PASS keygen.setAttribute("tabindex", "9999999999"); keygen.tabIndex is 0
PASS keygen.setAttribute("tabindex", "9999999999"); keygen.tabIndex is -1
PASS activeSummary.setAttribute("tabindex", "9999999999"); activeSummary.tabIndex is 0
PASS editableDiv.setAttribute("tabindex", "9999999999"); editableDiv.tabIndex is -1
PASS normalDiv.setAttribute("tabindex", "9999999999"); normalDiv.tabIndex is -1
Expand Down

0 comments on commit eb67381

Please sign in to comment.