Skip to content

Commit

Permalink
AX: Relative frames for RenderTables aren't being cached
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=267913
rdar://problem/121417745

Reviewed by Tyler Wilcock.

We had not been caching the relative frame of RenderTables on paint since they override RenderBlock::paintObject.

This starts caching those frames on paint.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):

Canonical link: https://commits.webkit.org/273394@main
  • Loading branch information
hoffmanjoshua committed Jan 24, 2024
1 parent 0c0655a commit ec4f492
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions LayoutTests/accessibility-isolated-tree/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ accessibility/mac/attributed-string/attributed-string-has-completion-annotation.
# Frames are off by 1px vs. non-ITM mode.
accessibility/table-cells.html [ Failure ]
accessibility/mac/document-links.html [ Failure ]
accessibility/table-with-rules.html [ Failure ]

accessibility/aria-owns-hierarchy-remap.html [ Failure ]
accessibility/element-reflection-ariaactivedescendant.html [ Failure ]
Expand Down
3 changes: 3 additions & 0 deletions Source/WebCore/rendering/RenderTable.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,9 @@ void RenderTable::paintObject(PaintInfo& paintInfo, const LayoutPoint& paintOffs
return;
}

if (paintPhase == PaintPhase::Accessibility)
paintInfo.accessibilityRegionContext()->takeBounds(*this, paintOffset);

// We're done. We don't bother painting any children.
if (paintPhase == PaintPhase::BlockBackground)
return;
Expand Down

0 comments on commit ec4f492

Please sign in to comment.