Merge r220677 - [GTK][WPE] Crash in IconDatabase::IconRecord::setImag…

…eData()

https://bugs.webkit.org/show_bug.cgi?id=175527

Reviewed by Žan Doberšek.

The problem is that when setImageData() is called from IconDatabase::readFromDatabase() the shared buffer might
be nullptr, because getImageDataForIconURLFromSQLDatabase() returns nullptr if the icon data is not in the database.

* UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::IconRecord::setImageData): Return early if passed in buffer is nullptr.

Source/WebKit/ChangeLog

@@ -1,3 +1,16 @@
+2017-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][WPE] Crash in IconDatabase::IconRecord::setImageData()
+        https://bugs.webkit.org/show_bug.cgi?id=175527
+
+        Reviewed by Žan Doberšek.
+
+        The problem is that when setImageData() is called from IconDatabase::readFromDatabase() the shared buffer might
+        be nullptr, because getImageDataForIconURLFromSQLDatabase() returns nullptr if the icon data is not in the database.
+
+        * UIProcess/API/glib/IconDatabase.cpp:
+        (WebKit::IconDatabase::IconRecord::setImageData): Return early if passed in buffer is nullptr.
+
 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
 
         Composition underline color is always black

Source/WebKit/UIProcess/API/glib/IconDatabase.cpp

@@ -120,7 +120,7 @@ void IconDatabase::IconRecord::setImageData(RefPtr<SharedBuffer>&& data)
     m_imageData = WTFMove(data);
     m_image = nullptr;
 
-    if (!m_imageData->size()) {
+    if (!m_imageData || !m_imageData->size()) {
         m_imageData = nullptr;
         return;
     }