Skip to content

Commit

Permalink
Merge r169768 - [GTK][gtkdoc] remove -Wcast-align
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=133640

Apparently gcc warns that GParamSpec is not castable to
GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
though ARM hackers claim that those only need 4byte alignment. As long as gcc
behaves that way, this warning is not very useful, also they break the Debian
packaging.

This patch appends the compiler flag -Wno-align-cast for the gtkdoc
scanner compilation, thus the compiler ignores the previous
-Waling-cast flag.

Reviewed by Martin Robinson.

* gtk/generate-gtkdoc:
(get_generator_for_config):
  • Loading branch information
ceyusa authored and carlosgcampos committed Jul 4, 2014
1 parent 3c00851 commit ee1a863
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
20 changes: 20 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,23 @@
2014-06-10 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>

[GTK][gtkdoc] remove -Wcast-align
https://bugs.webkit.org/show_bug.cgi?id=133640

Apparently gcc warns that GParamSpec is not castable to
GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
though ARM hackers claim that those only need 4byte alignment. As long as gcc
behaves that way, this warning is not very useful, also they break the Debian
packaging.

This patch appends the compiler flag -Wno-align-cast for the gtkdoc
scanner compilation, thus the compiler ignores the previous
-Waling-cast flag.

Reviewed by Martin Robinson.

* gtk/generate-gtkdoc:
(get_generator_for_config):

2014-05-30 Mario Sanchez Prada <mario.prada@samsung.com>

[ATK] Deprecate usage of logAccessibilityEvents() in layout tests
Expand Down
6 changes: 6 additions & 0 deletions Tools/gtk/generate-gtkdoc
Expand Up @@ -166,6 +166,12 @@ def prepare_environment_for_gtkdoc_generation():
# to compile it.
cflags = os.environ.get('CFLAGS', '')
cflags += ' -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_32'

# In non-x86 architectures, when a pointer is cast to (void*) and
# back, the compiler thinks that the alignment is random. Since
# gtkdoc build is broken at any warning message, it is better to
# silence these false positives.
cflags += ' -Wno-cast-align'
os.environ['CFLAGS'] = cflags

# Clang can be noisy, throwing unnecessary warnings for unused arguments.
Expand Down

0 comments on commit ee1a863

Please sign in to comment.