Skip to content

Commit

Permalink
[WPE] Fix libwpe version check WPEWebView destructor
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=271387

Reviewed by Adrian Perez de Castro.

WPEWebView destructor avoids calling 'wpe_view_backend_set_fullscreen_client'
for libwpe versions < 1.15.x - the fix appeared in 1.14.2, not 1.15.x - correct that.

Covered by existing tests, when executed with cog.

* Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp:
(WKWPE::View::~View):

Canonical link: https://commits.webkit.org/276729@main
  • Loading branch information
nikolaszimmermann authored and aperezdc committed Mar 27, 2024
1 parent 6e41b09 commit ef3fe7c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,8 @@ View::~View()
wpe_view_backend_set_backend_client(m_backend, nullptr, nullptr);
wpe_view_backend_set_input_client(m_backend, nullptr, nullptr);
// Although the fullscreen client is used for libwpe 1.11.1 and newer, we cannot
// unregister it prior to 1.15.2 (see https://github.com/WebPlatformForEmbedded/libwpe/pull/129).
#if ENABLE(FULLSCREEN_API) && WPE_CHECK_VERSION(1, 15, 2)
// unregister it prior to 1.14.2 (see https://github.com/WebPlatformForEmbedded/libwpe/pull/129).
#if ENABLE(FULLSCREEN_API) && WPE_CHECK_VERSION(1, 14, 2)
wpe_view_backend_set_fullscreen_client(m_backend, nullptr, nullptr);
#endif
}
Expand Down

0 comments on commit ef3fe7c

Please sign in to comment.