-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
REGRESSION(267944@main): wpt /css/CSS2/positioning/abspos-block-level…
…-001.html https://bugs.webkit.org/show_bug.cgi?id=263892 Reviewed by Antti Koivisto. This patch extends the logic of "is there an inflow content before this out of flow box" by taking inline direction into account. We already handle bidi (logical position vs. visual position) just fine but there's another layer of visual order here. When the content is RTL (again not to be confused with bidi) the logic of finding out if an out of flow box has preceding in flow content needs to start from the (visual) right edge and follow the inline direction. (i.e. in addition to resolving the logical -> visual order, we also need to travers these run lists in inline direction order) * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): (WebCore::Layout::setGeometryForOutOfFlowBoxes): (WebCore::Layout::InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h: (WebCore::Layout::InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes): Canonical link: https://commits.webkit.org/270069@main
- Loading branch information
1 parent
af06b86
commit f1664d7
Showing
4 changed files
with
94 additions
and
27 deletions.
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
LayoutTests/fast/block/right-to-left-out-of-flow-with-inflow-content-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<style> | ||
.container { | ||
direction: rtl; | ||
} | ||
.abs_pos { | ||
display: inline-block; | ||
width: 500px; | ||
height: 100px; | ||
background-color: blue; | ||
} | ||
</style> | ||
<div class=container>PASS if this text is visible<br><div class=abs_pos></div></div> |
12 changes: 12 additions & 0 deletions
12
LayoutTests/fast/block/right-to-left-out-of-flow-with-inflow-content.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<style> | ||
.container { | ||
direction: rtl; | ||
} | ||
.abs_pos { | ||
position: absolute; | ||
width: 500px; | ||
height: 100px; | ||
background-color: blue; | ||
} | ||
</style> | ||
<div class=container>PASS if this text is visible <div class=abs_pos></div></div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters