[GTK] Test /webkit/WebKitWebPage/context-menu is failing since r229831

https://bugs.webkit.org/show_bug.cgi?id=184260 Reviewed by Michael Catanzaro. This is not a regression introduced in r229831, though, it's a bug in the test itself revealed by r229831. We should wait for the load to complete before trying to show the context menu. * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp: (testContextMenuWebExtensionMenu): Canonical link: https://commits.webkit.org/199841@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Apr 4, 2018 · f1e4575 · f1e4575
1 parent 25138e5
commit f1e4575
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
@@ -1,3 +1,16 @@
+2018-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Test /webkit/WebKitWebPage/context-menu is failing since r229831
+        https://bugs.webkit.org/show_bug.cgi?id=184260
+
+        Reviewed by Michael Catanzaro.
+
+        This is not a regression introduced in r229831, though, it's a bug in the test itself revealed by r229831. We
+        should wait for the load to complete before trying to show the context menu.
+
+        * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
+        (testContextMenuWebExtensionMenu):
+
 2018-04-03  Zalan Bujtas  <zalan@apple.com>
 
         [LayoutReloaded] Introduce floating to InlineFormattingContext

diff --git a/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp b/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp
@@ -975,6 +975,7 @@ static void testContextMenuWebExtensionMenu(ContextMenuWebExtensionTest* test, g
 
     // Custom menu.
     test->loadHtml("<html><body></body></html>", "ContextMenuTestCustom");
+    test->waitUntilLoadFinished();
     test->showContextMenuAndWaitUntilFinished();
     g_assert_cmpuint(test->m_actions.size(), ==, 4);
     g_assert_cmpuint(test->m_actions[0], ==, WEBKIT_CONTEXT_MENU_ACTION_STOP);
@@ -984,6 +985,7 @@ static void testContextMenuWebExtensionMenu(ContextMenuWebExtensionTest* test, g
 
     // Menu cleared by the web process.
     test->loadHtml("<html><body></body></html>", "ContextMenuTestClear");
+    test->waitUntilLoadFinished();
     test->showContextMenuAndWaitUntilFinished();
     g_assert_cmpuint(test->m_actions.size(), ==, 0);
 }